Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner)!: add ego pose consideration #5036

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Sep 19, 2023

Description

We expand the polygon generation functions to consider the current ego pose, while the current implementation only consider the reference path's poses.
Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second).
image

Related links

related discussion
https://github.com/orgs/autowarefoundation/discussions/2859

Tests performed

The all of Polygon generations, obstacle labeling and velocity planning are works well in Psim.
Screencast from 09-13-2023 07:00:00 PM.webm

The new parameter enable_to_consider_current_pose is also works well.

For the case of this feature disabled, no behavior changes were observed by the tier4 internal tests.

Notes for reviewers

The function CreateOneStepPolygons() was move from the namespace polygon_utils to ObstacleCruisePlannerNode.
This is because CreateOneStepPolygons() require module parameters but does not include polygon operations.

Interface changes

We add two parameters for the obstacle cruise planner module.
These parameters are implemented in planning/obstacle_cruise_planner/config/obstacle_cruise_planner.param.yaml as

consider_current_pose:
        enable_to_consider_current_pose: false
        time_to_convergence: 1.5 #[s]

Effects on system behavior

We expected that there is no system behavior changes, because the new feature is disabled by the own parameter.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…error are assumed to decrease to zero by a specified constant time (e.g 1.5 second).

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…o-pose"

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 19, 2023
@yuki-takagi-66 yuki-takagi-66 changed the title Feat/obstacle cruise/cosider current ego pose awf main base feat(obstacle_cruise_planner)!: add ego pose consideration Sep 19, 2023
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…er/node.hpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2023
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 30.23% and project coverage change: -0.24% ⚠️

Comparison is base (08c809c) 15.81% compared to head (872ce6f) 15.58%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5036      +/-   ##
==========================================
- Coverage   15.81%   15.58%   -0.24%     
==========================================
  Files        1581     1587       +6     
  Lines      109933   109785     -148     
  Branches    34436    34055     -381     
==========================================
- Hits        17391    17111     -280     
- Misses      73406    73811     +405     
+ Partials    19136    18863     -273     
Flag Coverage Δ *Carryforward flag
differential 8.16% <30.23%> (?)
total 15.58% <ø> (-0.24%) ⬇️ Carriedforward from 9a24fe8

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.cpp 67.37% <ø> (+0.24%) ⬆️
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.hpp 25.00% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 24.73% <ø> (ø)
.../test/src/test_filter_in_vehicle_cmd_gate_node.cpp 60.81% <ø> (ø)
...icle_cmd_gate/test/src/test_vehicle_cmd_filter.cpp 37.69% <ø> (-0.13%) ⬇️
...planner/src/scene_module/start_planner/manager.cpp 4.82% <ø> (ø)
...cene_module/start_planner/start_planner_module.cpp 29.53% <ø> (-0.12%) ⬇️
...e_planner/include/obstacle_cruise_planner/node.hpp 10.52% <ø> (-0.59%) ⬇️
...atenate_data/concatenate_and_time_sync_nodelet.cpp 0.00% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 12.37% <16.12%> (+0.23%) ⬆️
... and 1 more

... and 60 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review September 21, 2023 07:21
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuki-takagi-66 yuki-takagi-66 merged commit f7a1b16 into autowarefoundation:main Sep 25, 2023
@yuki-takagi-66 yuki-takagi-66 deleted the feat/obstacle-cruise/cosider-current-ego-pose_awf-main-base branch September 25, 2023 07:24
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
…oundation#5036)

* feat: add the feature to consider the current ego position

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* feat: add ego pose consideration. Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second).

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* feat: (continue) implement parameter settings for "cosider-current-ego-pose"

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* cleaned up the code

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* change description of the parameters

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* align format

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* Update planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

* Update planning/obstacle_cruise_planner/src/node.cpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
…oundation#5036) (#942)

* feat: add the feature to consider the current ego position



* feat: add ego pose consideration. Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second).



* feat: (continue) implement parameter settings for "cosider-current-ego-pose"



* cleaned up the code



* change description of the parameters



* align format



* Update planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp



* Update planning/obstacle_cruise_planner/src/node.cpp



---------

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 16, 2023
…oundation#5036) (#942)

* feat: add the feature to consider the current ego position



* feat: add ego pose consideration. Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second).



* feat: (continue) implement parameter settings for "cosider-current-ego-pose"



* cleaned up the code



* change description of the parameters



* align format



* Update planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp



* Update planning/obstacle_cruise_planner/src/node.cpp



---------

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants