-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_cruise_planner)!: add ego pose consideration #5036
feat(obstacle_cruise_planner)!: add ego pose consideration #5036
Conversation
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…error are assumed to decrease to zero by a specified constant time (e.g 1.5 second). Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…o-pose" Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp
Outdated
Show resolved
Hide resolved
planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp
Outdated
Show resolved
Hide resolved
…er/node.hpp Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5036 +/- ##
==========================================
- Coverage 15.81% 15.58% -0.24%
==========================================
Files 1581 1587 +6
Lines 109933 109785 -148
Branches 34436 34055 -381
==========================================
- Hits 17391 17111 -280
- Misses 73406 73811 +405
+ Partials 19136 18863 -273
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oundation#5036) * feat: add the feature to consider the current ego position Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * feat: add ego pose consideration. Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second). Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * feat: (continue) implement parameter settings for "cosider-current-ego-pose" Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * cleaned up the code Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * change description of the parameters Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * align format Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * Update planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> * Update planning/obstacle_cruise_planner/src/node.cpp Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
…oundation#5036) (#942) * feat: add the feature to consider the current ego position * feat: add ego pose consideration. Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second). * feat: (continue) implement parameter settings for "cosider-current-ego-pose" * cleaned up the code * change description of the parameters * align format * Update planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp * Update planning/obstacle_cruise_planner/src/node.cpp --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
…oundation#5036) (#942) * feat: add the feature to consider the current ego position * feat: add ego pose consideration. Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second). * feat: (continue) implement parameter settings for "cosider-current-ego-pose" * cleaned up the code * change description of the parameters * align format * Update planning/obstacle_cruise_planner/include/obstacle_cruise_planner/node.hpp * Update planning/obstacle_cruise_planner/src/node.cpp --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Description
We expand the polygon generation functions to consider the current ego pose, while the current implementation only consider the reference path's poses.
![image](https://private-user-images.githubusercontent.com/141538661/269514041-b7817359-89a4-412f-841b-7f678269cbb1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMDQyMDcsIm5iZiI6MTczOTMwMzkwNywicGF0aCI6Ii8xNDE1Mzg2NjEvMjY5NTE0MDQxLWI3ODE3MzU5LTg5YTQtNDEyZi04NDFiLTdmNjc4MjY5Y2JiMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxOTU4MjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xY2Q4NDU5MTYyM2VlMWVlOGVhMzEwYWQ0YjUxMWFmNzVmZDM5NDdkNDQ1MTQzMmVhY2Q2MmEyYWRiMDdkOWQyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.1CzJ88tg9i13t9ovxUvNJhd_4HmYXNZ1q4B0WSY4REw)
Both the lateral error and the yaw error are assumed to decrease to zero by a specified constant time (e.g 1.5 second).
Related links
related discussion
https://github.com/orgs/autowarefoundation/discussions/2859
Tests performed
The all of Polygon generations, obstacle labeling and velocity planning are works well in Psim.
Screencast from 09-13-2023 07:00:00 PM.webm
The new parameter
enable_to_consider_current_pose
is also works well.For the case of this feature disabled, no behavior changes were observed by the tier4 internal tests.
Notes for reviewers
The function
CreateOneStepPolygons()
was move from the namespacepolygon_utils
toObstacleCruisePlannerNode
.This is because
CreateOneStepPolygons()
require module parameters but does not include polygon operations.Interface changes
We add two parameters for the obstacle cruise planner module.
These parameters are implemented in
planning/obstacle_cruise_planner/config/obstacle_cruise_planner.param.yaml
asEffects on system behavior
We expected that there is no system behavior changes, because the new feature is disabled by the own parameter.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.