Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(obstacle_cruise): proper handle with backward paths in the polygon expansion #5703

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix(obstacle_cruise): proper handle with backward paths in the polygon expansion #5703

merged 2 commits into from
Nov 30, 2023

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Nov 28, 2023 •
edited
Loading

Description

Bug fix of the function introduced in #5036
Proper handling with backwad paths is achived

Tests performed

psim test performed
Before:
image

After:
image
image

Not applicable.

Effects on system behavior

See Description

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yuki-takagi-66
proper handle with backward paths in the polygon expansion
0168de2 
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 28, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 28, 2023
@yuki-takagi-66 yuki-takagi-66 changed the title proper handle with backward paths in the polygon expansion fix(obstacle_cruise): proper handle with backward paths in the polygon expansion Nov 28, 2023
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review November 28, 2023 11:33
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (042c7a0) 15.27% compared to head (848bb81) 15.25%.
Report is 115 commits behind head on main.

Files Patch % Lines
...ity_intersection_module/src/scene_intersection.cpp 0.00% 38 Missing ⚠️
...tion/geo_pose_projector/src/geo_pose_projector.cpp 0.00% 36 Missing ⚠️
...behavior_velocity_intersection_module/src/util.cpp 0.00% 23 Missing ⚠️
...geo_pose_projector/src/geo_pose_projector_node.cpp 0.00% 4 Missing ⚠️
...ction_module/src/scene_merge_from_private_road.cpp 0.00% 2 Missing ⚠️
planning/obstacle_cruise_planner/src/node.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5703      +/-   ##
==========================================
- Coverage   15.27%   15.25%   -0.02%     
==========================================
  Files        1713     1715       +2     
  Lines      118179   118349     +170     
  Branches    37790    37873      +83     
==========================================
+ Hits        18048    18060      +12     
- Misses      79582    79725     +143     
- Partials    20549    20564      +15
Flag Coverage Δ *Carryforward flag
differential 8.28% <80.00%> (?)
total 15.26% <0.00%> (-0.01%) ⬇️ Carriedforward from 0168de2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66
call another findNearestSegmentIndex()
848bb81 
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
satoshi-ota
satoshi-ota approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuki-takagi-66 yuki-takagi-66 merged commit 061609a into autowarefoundation:main Nov 30, 2023
20 of 25 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the fix/obstacle_cruise-polygon-expansion branch November 30, 2023 03:24
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 6, 2023
Merged
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
@yuki-takagi-66 @danielsanchezaran
fix(obstacle_cruise): proper handle with backward paths in the polygo…
43c82b4 
…n expansion (autowarefoundation#5703)

* proper handle with backward paths in the polygon expansion

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoshi-ota satoshi-ota satoshi-ota approved these changes

@kosuke55 kosuke55 Awaiting requested review from kosuke55

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

Assignees

@satoshi-ota satoshi-ota

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuki-takagi-66 @satoshi-ota