Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): remove tier4_autoware_utils.hpp sensing/ #4841

Merged
merged 2 commits into from
Sep 4, 2023
Merged

chore(build): remove tier4_autoware_utils.hpp sensing/ #4841

merged 2 commits into from
Sep 4, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 1, 2023

Description

#4821

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 1, 2023
@soblin soblin changed the title chore(build): remove tier4 autoware utils hpp sensing/ chore(build): remove tier4_autoware_utils.hpp sensing/ Sep 1, 2023
@soblin
removed tier4_autoware_utils.hpp in sensing/
d4fa35d 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the build-fast2/component/sensing/remove-tier4_autoware_utils_hpp branch from 56152c9 to d4fa35d Compare September 1, 2023 04:30
@github-actions github-actions bot removed component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 1, 2023
@soblin soblin marked this pull request as ready for review September 1, 2023 06:19
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 1, 2023
@soblin
Copy link
Contributor Author

soblin commented Sep 1, 2023

Merge this after #4849

@soblin
Copy link
Contributor Author

soblin commented Sep 2, 2023

@scepter914 Can you approve this PR ?

scepter914
scepter914 approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kminoda
kminoda approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit 1d55094 into autowarefoundation:main Sep 4, 2023
@soblin soblin deleted the build-fast2/component/sensing/remove-tier4_autoware_utils_hpp branch September 4, 2023 04:58
@kminoda kminoda mentioned this pull request Sep 4, 2023
Merged
4 tasks
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scepter914 scepter914 scepter914 approved these changes

@kminoda kminoda kminoda approved these changes

@miursh miursh Awaiting requested review from miursh

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo

Assignees
No one assigned
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soblin @scepter914 @kminoda