Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add nlohmann-json-dev dependency #4795

Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Aug 29, 2023

Description

Added missing nlohmann-json-dev dependency

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 29, 2023
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve enabled auto-merge (squash) August 29, 2023 14:05
@esteve esteve force-pushed the add-nlohmann-json-dev-dependency branch from cb3f0a1 to f3465c5 Compare August 29, 2023 14:05
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the add-nlohmann-json-dev-dependency branch from f3465c5 to c5d7e64 Compare August 29, 2023 14:07
@esteve
Copy link
Contributor Author

esteve commented Aug 29, 2023

@YoshiRi @scepter914 thanks for your reviews. I don't know why, but CI seems to be stuck in build-and-the test-differential, any ideas? Thanks.

@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 29, 2023
@YoshiRi
Copy link
Contributor

YoshiRi commented Aug 29, 2023

@esteve
Due to the recent change in autoware CI, we need to add run-build-and-test-differential label manually to run build-and-the test-differential. (Maybe because of the computation resource issue.)

Just add this label when approved PR does not have it👍

@esteve esteve merged commit de28252 into autowarefoundation:main Aug 29, 2023
@esteve esteve deleted the add-nlohmann-json-dev-dependency branch August 29, 2023 14:56
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 30, 2023
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants