-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add nlohmann-json-dev dependency #4795
build: add nlohmann-json-dev dependency #4795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cb3f0a1
to
f3465c5
Compare
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
f3465c5
to
c5d7e64
Compare
@YoshiRi @scepter914 thanks for your reviews. I don't know why, but CI seems to be stuck in build-and-the test-differential, any ideas? Thanks. |
@esteve Just add this label when approved PR does not have it👍 |
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Description
Added missing nlohmann-json-dev dependency
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.