-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radar_fusion_sync_policy): change sync policy for radar_fusion_to_detected_object #4780
fix(radar_fusion_sync_policy): change sync policy for radar_fusion_to_detected_object #4780
Conversation
…_detected_object Signed-off-by: scepter914 <scepter914@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4780 +/- ##
==========================================
+ Coverage 15.11% 15.16% +0.05%
==========================================
Files 1568 1568
Lines 108176 107693 -483
Branches 33218 32802 -416
==========================================
- Hits 16346 16335 -11
+ Misses 74013 73868 -145
+ Partials 17817 17490 -327
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…_detected_object (autowarefoundation#4780) Signed-off-by: scepter914 <scepter914@gmail.com>
…_detected_object (autowarefoundation#4780) Signed-off-by: scepter914 <scepter914@gmail.com>
Description
This PR changes the sync policy of
radar_fusion_to_detected_object
.Due to the bigger functions of Camera-LiDAR fusion, it took time to output objects using Camera-LiDAR fusion.
Therefore, there was a time difference with the radar object, and there were cases where the object was not output by the message filter of radar fusion.
This PR loosen the sync policy of
radar_fusion_to_detected_object
.Tests performed
Test by rosbag.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.