Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_fusion_sync_policy): change sync policy for radar_fusion_to_detected_object #4780

Merged

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Aug 28, 2023

Description

This PR changes the sync policy of radar_fusion_to_detected_object.

  • Background

Due to the bigger functions of Camera-LiDAR fusion, it took time to output objects using Camera-LiDAR fusion.
Therefore, there was a time difference with the radar object, and there were cases where the object was not output by the message filter of radar fusion.

  • Change points

This PR loosen the sync policy of radar_fusion_to_detected_object.

Tests performed

Test by rosbag.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…_detected_object

Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 requested a review from miursh as a code owner August 28, 2023 07:55
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 28, 2023
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05% 🎉

Comparison is base (7a4a905) 15.11% compared to head (72cd2bc) 15.16%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4780      +/-   ##
==========================================
+ Coverage   15.11%   15.16%   +0.05%     
==========================================
  Files        1568     1568              
  Lines      108176   107693     -483     
  Branches    33218    32802     -416     
==========================================
- Hits        16346    16335      -11     
+ Misses      74013    73868     -145     
+ Partials    17817    17490     -327     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.16% <ø> (+0.05%) ⬆️ Carriedforward from a62105c

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 24.65% <ø> (+0.06%) ⬆️
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <ø> (ø)
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp 9.61% <ø> (+0.68%) ⬆️
...jection_loader/src/load_info_from_lanelet2_map.cpp 42.85% <ø> (+7.56%) ⬆️
...ap_projection_loader/src/map_projection_loader.cpp 25.00% <ø> (-1.67%) ⬇️
...de/radar_object_fusion_to_detected_object_node.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.36% <ø> (-0.15%) ⬇️
...ointcloud2_node/radar_scan_to_pointcloud2_node.cpp 0.00% <ø> (ø)
system/default_ad_api/src/vehicle.cpp 14.28% <ø> (+0.39%) ⬆️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scepter914 scepter914 enabled auto-merge (squash) August 29, 2023 12:09
@scepter914 scepter914 merged commit b56dd82 into autowarefoundation:main Aug 29, 2023
@scepter914 scepter914 deleted the fix/radar_fusion_sync_policy branch August 29, 2023 12:56
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 30, 2023
…_detected_object (autowarefoundation#4780)

Signed-off-by: scepter914 <scepter914@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Oct 16, 2023
…_detected_object (autowarefoundation#4780)

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants