Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_crosswalk_module): use std::optional instead of boost::optional #4311

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 18, 2023

Description

Depends on #4284

use std::optional instead of boost::optional

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 force-pushed the refactor/use-optional-in-crosswalk branch from 6922164 to a3ad9ce Compare July 18, 2023 05:11
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (665281e) 14.17% compared to head (381b52b) 14.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4311      +/-   ##
==========================================
- Coverage   14.17%   14.17%   -0.01%     
==========================================
  Files        1601     1601              
  Lines      110214   110217       +3     
  Branches    31602    31611       +9     
==========================================
  Hits        15623    15623              
- Misses      77603    77606       +3     
  Partials    16988    16988              
Flag Coverage Δ *Carryforward flag
differential 11.35% <0.00%> (?)
total 14.18% <ø> (+0.01%) ⬆️ Carriedforward from 665281e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...g/behavior_velocity_crosswalk_module/src/debug.cpp 0.00% <0.00%> (ø)
...behavior_velocity_crosswalk_module/src/manager.cpp 21.73% <0.00%> (ø)
...behavior_velocity_crosswalk_module/src/manager.hpp 100.00% <ø> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <0.00%> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.hpp 0.00% <ø> (ø)
...or_velocity_crosswalk_module/src/scene_walkway.cpp 0.00% <0.00%> (ø)
...ng/behavior_velocity_crosswalk_module/src/util.cpp 0.00% <0.00%> (ø)
...ng/behavior_velocity_crosswalk_module/src/util.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota
Copy link
Contributor

satoshi-ota commented Jul 18, 2023

Thanks @takayuki5168 for your PR.
Just curious. Could you tell me the reason why you would like to use std:optional instead of boost one.

…ad of boost::optional

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/use-optional-in-crosswalk branch from a3ad9ce to 381b52b Compare July 19, 2023 00:03
@takayuki5168
Copy link
Contributor Author

@satoshi-ota
In C++, the boost supports the experimental features ahead of std. Now we can use C++17 because of the ROS2 update where optional is supported in std.
Therefore, it would be better to use the official optional of std.

@satoshi-ota
Copy link
Contributor

@satoshi-ota In C++, the boost supports the experimental features ahead of std. Now we can use C++17 because of the ROS2 update where optional is supported in std. Therefore, it would be better to use the official optional of std.

OK. I got it.

@takayuki5168 takayuki5168 merged commit 37cbd8d into autowarefoundation:main Jul 19, 2023
@takayuki5168 takayuki5168 deleted the refactor/use-optional-in-crosswalk branch July 19, 2023 04:00
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jul 19, 2023
…ad of boost::optional (autowarefoundation#4311)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jul 20, 2023
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…ad of boost::optional (autowarefoundation#4311)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants