Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_walkway_module): add a new module #4315

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 18, 2023

Description

Depends on #4284 and #4311

separate a new package behavior_velocity_walkway_module from behavior_velocity_crosswalk_module for higher readability & maintainability

launcher PR: autowarefoundation/autoware_launch#458

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 18, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review July 18, 2023 08:58
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/separate-walkway-module branch from 963a479 to 7878866 Compare July 19, 2023 04:01
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 21.21% and project coverage change: -0.01 ⚠️

Comparison is base (37cbd8d) 15.17% compared to head (2f3adc4) 15.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4315      +/-   ##
==========================================
- Coverage   15.17%   15.16%   -0.01%     
==========================================
  Files        1493     1498       +5     
  Lines      102964   103028      +64     
  Branches    31611    31649      +38     
==========================================
  Hits        15623    15623              
- Misses      70353    70417      +64     
  Partials    16988    16988              
Flag Coverage Δ *Carryforward flag
differential 11.35% <21.21%> (?)
total 15.16% <ø> (-0.01%) ⬇️ Carriedforward from 37cbd8d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nclude/behavior_velocity_crosswalk_module/util.hpp 0.00% <ø> (ø)
...g/behavior_velocity_crosswalk_module/src/debug.cpp 0.00% <ø> (ø)
...behavior_velocity_crosswalk_module/src/manager.cpp 15.06% <ø> (-6.68%) ⬇️
...behavior_velocity_crosswalk_module/src/manager.hpp 100.00% <ø> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.hpp 0.00% <ø> (ø)
..._velocity_planner/test/src/test_node_interface.cpp 26.53% <ø> (ø)
...ing/behavior_velocity_walkway_module/src/debug.cpp 0.00% <0.00%> (ø)
...vior_velocity_walkway_module/src/scene_walkway.cpp 0.00% <ø> (ø)
...g/behavior_velocity_walkway_module/src/manager.cpp 23.80% <23.80%> (ø)
...ng/behavior_velocity_crosswalk_module/src/util.cpp 14.06% <39.13%> (+14.06%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 92b78db into autowarefoundation:main Jul 19, 2023
@takayuki5168 takayuki5168 deleted the refactor/separate-walkway-module branch July 19, 2023 13:32
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jul 19, 2023
…efoundation#4315)

* add behavior_velocity_walkway_module package

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update README

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update behavior_velocity_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jul 20, 2023
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…efoundation#4315)

* add behavior_velocity_walkway_module package

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update README

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update behavior_velocity_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants