-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_walkway_module): add a new module #4315
Merged
takayuki5168
merged 5 commits into
autowarefoundation:main
from
tier4:refactor/separate-walkway-module
Jul 19, 2023
Merged
refactor(behavior_velocity_walkway_module): add a new module #4315
takayuki5168
merged 5 commits into
autowarefoundation:main
from
tier4:refactor/separate-walkway-module
Jul 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
soblin
approved these changes
Jul 18, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
963a479
to
7878866
Compare
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota
approved these changes
Jul 19, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4315 +/- ##
==========================================
- Coverage 15.17% 15.16% -0.01%
==========================================
Files 1493 1498 +5
Lines 102964 103028 +64
Branches 31611 31649 +38
==========================================
Hits 15623 15623
- Misses 70353 70417 +64
Partials 16988 16988
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 19, 2023
…efoundation#4315) * add behavior_velocity_walkway_module package Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update README Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update behavior_velocity_planner Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 20, 2023
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 9, 2023
…efoundation#4315) * add behavior_velocity_walkway_module package Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update README Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update behavior_velocity_planner Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #4284 and #4311
separate a new package
behavior_velocity_walkway_module
frombehavior_velocity_crosswalk_module
for higher readability & maintainabilitylauncher PR: autowarefoundation/autoware_launch#458
Tests performed
planning simulator
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.