Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): use non shifted path is shift line idx invalid #4227

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Jul 10, 2023

Description

While Shift Pull Out module in the start planner is planning for path, the path shifter's generation fails because the lateral shift distance is small during the start-up from the central line, resulting in the start_idx and end_idx being the same.

This PR aims to fix this by inserting non_shifted_path during the start_idx - end_idx <= 1 situation.

Related links

None

Tests performed

In the start planner's param file, set enable_back: false

place ego pose as follows

position x: 61444.953125 
position y: 56224.13671875
orientation z: -0.0680803539122891
orientation w: 0.997679841137014

and goal pose as follows

position x: 61396.
position y: 56226.2
orientation z: 0.27939585430954345
orientation w: 0.9601760029258388

And confirm that Shift Pull Out module is running.
Also the behavior path planner container should be alive.

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 10, 2023
@kosuke55
Copy link
Contributor

@zulfaqar-azmi-t4
thanks very much! the code looks good! but this PR fixed issue when enable_back: false.
The lateral shift distance is too short and fails to generate a shifted path.
I think the problem of Description when enable_back: true is different from this PR.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d4bb8bd) 14.22% compared to head (64ad32c) 14.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4227      +/-   ##
==========================================
- Coverage   14.22%   14.22%   -0.01%     
==========================================
  Files        1594     1594              
  Lines      109681   109685       +4     
  Branches    31487    31489       +2     
==========================================
  Hits        15603    15603              
- Misses      77132    77136       +4     
  Partials    16946    16946              
Flag Coverage Δ *Carryforward flag
differential 13.66% <0.00%> (?)
total 14.22% <ø> (ø) Carriedforward from d4bb8bd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planner/src/utils/start_planner/shift_pull_out.cpp 2.89% <0.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 7bc034a into autowarefoundation:main Jul 11, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix/start-planner-non-shifted branch July 11, 2023 02:14
kosuke55 added a commit that referenced this pull request Jul 11, 2023
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants