-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start_planner): publish stop path when goal is behind from ego #4214
fix(start_planner): publish stop path when goal is behind from ego #4214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, LGTM!!
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
762e1fa
to
a35f4e2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4214 +/- ##
==========================================
+ Coverage 14.16% 14.20% +0.03%
==========================================
Files 1586 1597 +11
Lines 109537 109835 +298
Branches 31451 31504 +53
==========================================
+ Hits 15518 15603 +85
- Misses 77130 77283 +153
- Partials 16889 16949 +60
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…utowarefoundation#4214) * fix(start_planner): publish stop path when goal is behind from ego Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * pre-commit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
The path is not well calculated when the goal is set behind from ego.
before:
![image](https://private-user-images.githubusercontent.com/21360593/252274775-a875a53e-615b-44a4-9d3a-94adaee85af6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNzI3MjQsIm5iZiI6MTczOTM3MjQyNCwicGF0aCI6Ii8yMTM2MDU5My8yNTIyNzQ3NzUtYTg3NWE1M2UtNjE1Yi00NGE0LTlkM2EtOTRhZGFlZTg1YWY2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE1MDAyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWExZmVhZmEyNDU4M2QxYTQ1NzM1MmY1N2NmNzhjMTI4NDQ4ODBmOTY2MGVkZWZlZDQ1NzY5ZTA4NDM4Y2I1MmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.XFG8z2RW3bXzMs69GtExSxwKnGwpuJIT0EGUuT2Sb_c)
Now since the plan for a backward direction is not supported, add a function in the start_planner to skip planning when the ego is behind from ego with a warning message.
after:
![image](https://private-user-images.githubusercontent.com/21360593/252275124-39c8f3c0-6559-45b2-8d1e-95915a812c30.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNzI3MjQsIm5iZiI6MTczOTM3MjQyNCwicGF0aCI6Ii8yMTM2MDU5My8yNTIyNzUxMjQtMzljOGYzYzAtNjU1OS00NWIyLThkMWUtOTU5MTVhODEyYzMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE1MDAyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYyNTExNzk0NWU0ZmY2ZDgwZWI2NWJlMjEyODJmODM2YTQzZThjM2QxYzIwYzEwNTlhOGRlYjIwOGVkZmY3YzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.hxgiNKoyfW5fw9StG_eKw1lh2yCbtJZszeKaXbUYOrE)
Related links
TIERIV internal link
Tests performed
run psim
Link for scenario test in TIERIV
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.