Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): publish stop path when goal is behind from ego #4214

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jul 10, 2023

Description

The path is not well calculated when the goal is set behind from ego.

before:
image

Now since the plan for a backward direction is not supported, add a function in the start_planner to skip planning when the ego is behind from ego with a warning message.

after:
image

Related links

TIERIV internal link

Tests performed

run psim

Link for scenario test in TIERIV

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 10, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM!!

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe force-pushed the fix-start-planner-undesired-back branch from 762e1fa to a35f4e2 Compare July 11, 2023 02:25
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 20.06% and project coverage change: +0.03 🎉

Comparison is base (8c982e5) 14.16% compared to head (a35f4e2) 14.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4214      +/-   ##
==========================================
+ Coverage   14.16%   14.20%   +0.03%     
==========================================
  Files        1586     1597      +11     
  Lines      109537   109835     +298     
  Branches    31451    31504      +53     
==========================================
+ Hits        15518    15603      +85     
- Misses      77130    77283     +153     
- Partials    16889    16949      +60     
Flag Coverage Δ *Carryforward flag
differential 13.67% <2.68%> (?)
total 14.23% <27.56%> (+0.06%) ⬆️ Carriedforward from 0795882

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r4_planning_rviz_plugin/src/tools/max_velocity.cpp 0.00% <0.00%> (ø)
control/shift_decider/src/shift_decider.cpp 0.00% <ø> (ø)
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% <0.00%> (ø)
...object_clustering/radar_object_clustering_node.hpp 0.00% <0.00%> (ø)
...t_clustering_node/radar_object_clustering_node.cpp 0.00% <0.00%> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...nner/scene_module/lane_change/external_request.hpp 0.00% <ø> (ø)
...ath_planner/scene_module/lane_change/interface.hpp 100.00% <ø> (+50.00%) ⬆️
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 0.00% <ø> (ø)
... and 29 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit bc5e66b into autowarefoundation:main Jul 11, 2023
@kosuke55 kosuke55 deleted the fix-start-planner-undesired-back branch July 11, 2023 07:28
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 20, 2023
…utowarefoundation#4214)

* fix(start_planner): publish stop path when goal is behind from ego

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* pre-commit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

---------

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants