Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_loader): use cylindrical area for map loader #3863

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented May 30, 2023

Description

Background

pose_initializer (map_height_fitter) failed when the z of pointcloud map was over 50m (or under -50m). This was due to the spherical area query in partial_map_loading. Instead, we should use cylindrical area query with infinite height.

Changes

Change AreaInfo.msg, which is used as an query to load a specific pointcloud maps in that area, as follows

Before:

# Area info used as a query in map loading service
# Note: this only supports spherical area message for now

geometry_msgs/Point center
float32 radius

After

# Area info used as a query in map loading service
# Note: this only supports cylindrical area message for now

float32 center_x
float32 center_y
float32 radius

I changed some nodes that uses the interface accordingly.

Related links

Tests performed

Confirmed that logging_simulator works with a sample map and rosbag

Notes for reviewers

No performance changes (except map_height_fitter)

Interface changes

AreaInfo.msg in autoware_map_msgs changes.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda added 2 commits May 30, 2023 14:43
… area

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label May 30, 2023
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels May 30, 2023
@kminoda kminoda marked this pull request as ready for review May 30, 2023 08:24
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding compare_map_segmentation

Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this by running logging_simulator with split sample maps. And it worked correctly. 👍

Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda changed the title feat(map_loader) use cylindrical area for map loader feat(map_loader): use cylindrical area for map loader Jun 1, 2023
@kminoda
Copy link
Contributor Author

kminoda commented Jun 1, 2023

@isamu-takagi @YamatoAndo Could you review this PR as well? (Please dismiss the failing CI, as this PR is also related to autoware_msgs modicification)

Copy link
Contributor

@YamatoAndo YamatoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding map_height_fitter

@kminoda kminoda enabled auto-merge (squash) June 1, 2023 06:04
@kminoda kminoda merged commit 7b34e1b into autowarefoundation:main Jun 1, 2023
@kminoda kminoda deleted the feat/use_cylindrical_area_for_map_loader branch August 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

6 participants