-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_loader): use cylindrical area for map loader #3863
feat(map_loader): use cylindrical area for map loader #3863
Conversation
… area Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM regarding compare_map_segmentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this by running logging_simulator with split sample maps. And it worked correctly. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@isamu-takagi @YamatoAndo Could you review this PR as well? (Please dismiss the failing CI, as this PR is also related to autoware_msgs modicification) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM regarding map_height_fitter
Description
Background
pose_initializer (map_height_fitter) failed when the z of pointcloud map was over 50m (or under -50m). This was due to the spherical area query in
partial_map_loading
. Instead, we should use cylindrical area query with infinite height.Changes
Change AreaInfo.msg, which is used as an query to load a specific pointcloud maps in that area, as follows
Before:
After
I changed some nodes that uses the interface accordingly.
Related links
Tests performed
Confirmed that logging_simulator works with a sample map and rosbag
Notes for reviewers
No performance changes (except
map_height_fitter
)Interface changes
AreaInfo.msg in autoware_map_msgs changes.
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.