Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_map_msgs): support cylindrical AreaInfo #64

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented May 30, 2023

Description

Please see here: autowarefoundation/autoware.universe#3863

Related links

Tests performed

Confirmed that logging_simulator works with a sample map and rosbag

Notes for reviewers

Interface changes

Change AreaInfo.msg (spherical query to cylindrical query)

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as ready for review May 30, 2023 08:26
@kminoda kminoda requested review from YamatoAndo and mitsudome-r May 30, 2023 08:26
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit c2a82f3 into autowarefoundation:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants