Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_occlusion_spot_module): delete unnecessary arg from member function of VirtualWallMarkerCreator #3832

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented May 26, 2023

Description

Related with #3769

There are two types of scene module exist in behavior_velocity_planner.

  • multiple module can be launched
  • only one module can be launched

And occlusion_spot_module is the type of only one module can be launched.

So prefix of namespace is unnecesary. Thi PR delete arg used for prefix.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (712c11c) 14.11% compared to head (27a65af) 14.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3832   +/-   ##
=======================================
  Coverage   14.11%   14.11%           
=======================================
  Files        1438     1438           
  Lines      101526   101526           
  Branches    27045    27045           
=======================================
  Hits        14328    14328           
  Misses      71513    71513           
  Partials    15685    15685           
Flag Coverage Δ *Carryforward flag
differential 11.33% <ø> (?)
total 14.11% <ø> (ø) Carriedforward from 712c11c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...avior_velocity_occlusion_spot_module/src/debug.cpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review May 26, 2023 06:41
@kyoichi-sugahara kyoichi-sugahara requested a review from soblin May 26, 2023 06:44
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara merged commit 76bf751 into autowarefoundation:main May 26, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the fix/virtual_wall_marker_creator_bug_occulusion_spot branch May 29, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants