Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): add mrm reroute #3821

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented May 25, 2023

Description

Add rerouting functions for MRM. This enables autoware to generate a new route when it is in a danger.

Related links

Tests performed

Planning Simulator

Notes for reviewers

Interface changes

There are no interface changes.

Effects on system behavior

No effects on system behavior unless the ego vehicle requires to generate a new path in a mrm state

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.96 🎉

Comparison is base (712c11c) 14.11% compared to head (ec8961a) 15.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3821      +/-   ##
==========================================
+ Coverage   14.11%   15.07%   +0.96%     
==========================================
  Files        1438     1332     -106     
  Lines      101526    95013    -6513     
  Branches    27045    27045              
==========================================
- Hits        14328    14326       -2     
+ Misses      71513    65001    -6512     
- Partials    15685    15686       +1     
Flag Coverage Δ *Carryforward flag
differential 13.67% <0.00%> (?)
total 15.10% <ø> (+0.98%) ⬆️ Carriedforward from 96d22a6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)

... and 109 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 358d4a7 into main May 26, 2023
@purewater0901 purewater0901 deleted the feat/add-mrm-reroute branch May 26, 2023 04:17
kosuke55 added a commit that referenced this pull request May 26, 2023
kosuke55 added a commit that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants