Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mission_planner): revert add mrm reroute (#3821) #3831

Merged
merged 1 commit into from
May 26, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented May 26, 2023

This reverts commit 358d4a7.

Description

#3821 changed API behavior, so revert this.
We need to discuss this more.

Related links

#3821

Tests performed

not tested

Notes for reviewers

Interface changes

no applicable

Effects on system behavior

no applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 marked this pull request as ready for review May 26, 2023 04:55
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 26, 2023
@kosuke55 kosuke55 enabled auto-merge (squash) May 26, 2023 04:58
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (712c11c) 14.11% compared to head (6d5cd0c) 14.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3831   +/-   ##
=======================================
  Coverage   14.11%   14.11%           
=======================================
  Files        1438     1438           
  Lines      101526   101526           
  Branches    27045    27045           
=======================================
  Hits        14328    14328           
  Misses      71513    71513           
  Partials    15685    15685           
Flag Coverage Δ *Carryforward flag
differential 15.08% <0.00%> (?)
total 14.11% <0.00%> (ø) Carriedforward from 712c11c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 changed the title Revert "feat(mission_planner): add mrm reroute (#3821)" fix(mission_planner): revert add mrm reroute (#3821) May 26, 2023
@kosuke55 kosuke55 merged commit 1fa7bfd into main May 26, 2023
@kosuke55 kosuke55 deleted the revert/mrm_reroute branch May 26, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants