Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(behavior_path_planner): rename pull_over to goal_planner #3501

Merged
merged 1 commit into from
Apr 26, 2023
Merged

refactor(behavior_path_planner): rename pull_over to goal_planner #3501

merged 1 commit into from
Apr 26, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Apr 23, 2023 •
edited
Loading

Description

rename pull_over to goal_planner

Related links

Tests performed

psim
tier4 intearnal scenario test 1318/1330
pull over 74/74 -> 69/74, but these are not related to this PR, I will fix them later.

Notes for reviewers

Interface changes

some topics chage from pull_over to goal_planner

  • /planning/cooperate_status/goal_planner
  • /planning/path_candidate/goal_planner
  • /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/debug/goal_planner
  • /planning/steering_factor/goal_planner

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Apr 23, 2023
@kosuke55 kosuke55 mentioned this pull request Apr 23, 2023
Merged
7 tasks
@kosuke55
Copy link
Contributor Author

merge after #3454

yukkysaito
yukkysaito approved these changes Apr 23, 2023
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Apr 24, 2023
@kosuke55 kosuke55 force-pushed the refactor/rename_goal_planner branch from 9240adc to e0bddc2 Compare April 25, 2023 02:13
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) and removed component:common Common packages from the autoware-common repository. (auto-assigned) labels Apr 25, 2023
@kosuke55
Copy link
Contributor Author

passing ci needs

@kosuke55
Copy link
Contributor Author

@tkimura4 @rej55 @taikitanaka3
could you please approve this as a code owner? this is just renaming PR.

@kosuke55 kosuke55 changed the title Refactor/rename goal planner refactor(behavior_path_planenr): renaem pull_over to goal_planner Apr 25, 2023
@kosuke55 kosuke55 changed the title refactor(behavior_path_planenr): renaem pull_over to goal_planner refactor(behavior_path_planner): renaem pull_over to goal_planner Apr 25, 2023
@kosuke55 kosuke55 changed the title refactor(behavior_path_planner): renaem pull_over to goal_planner refactor(behavior_path_planner): rename pull_over to goal_planner Apr 25, 2023
@kosuke55 kosuke55 force-pushed the refactor/rename_goal_planner branch from 6f62cca to de7784b Compare April 25, 2023 12:48
@kosuke55 kosuke55 mentioned this pull request Apr 25, 2023
Merged
7 tasks
@kosuke55 kosuke55 force-pushed the refactor/rename_goal_planner branch from de7784b to 8787567 Compare April 25, 2023 14:03
@taikitanaka3
Copy link
Contributor

@kosuke55 please write description of interface change.

@kosuke55 kosuke55 force-pushed the refactor/rename_goal_planner branch 3 times, most recently from 24007bf to 618d2c3 Compare April 25, 2023 15:59
@kosuke55
Copy link
Contributor Author

@taikitanaka3
thanks, I added description of interface change.

@kosuke55 kosuke55 force-pushed the refactor/rename_goal_planner branch from 618d2c3 to b95ee6c Compare April 26, 2023 00:01
taikitanaka3
taikitanaka3 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for rtc manager panel

@kosuke55 kosuke55 force-pushed the refactor/rename_goal_planner branch from b95ee6c to cc168f4 Compare April 26, 2023 01:07
@kosuke55 kosuke55 mentioned this pull request Apr 26, 2023
Merged
7 tasks
@kosuke55
refactor(behavior_path_planner): rename pull_over to goal_planner
98970ba 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the refactor/rename_goal_planner branch from cc168f4 to 98970ba Compare April 26, 2023 02:01
@kosuke55 kosuke55 requested a review from h-ohta as a code owner April 26, 2023 02:01
@kosuke55
Copy link
Contributor Author

check with RTC

goal_planner.mp4

@kosuke55
Copy link
Contributor Author

@isamu-takagi @h-ohta
could you please check as a code owner of rtc_maneger_panel?:pray:

@kosuke55 kosuke55 merged commit 62291d0 into main Apr 26, 2023
@kosuke55 kosuke55 deleted the refactor/rename_goal_planner branch April 26, 2023 04:56
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Apr 26, 2023
Merged
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
@kosuke55 @Mingyu1991
refactor(behavior_path_planner): rename pull_over to goal_planner (au…
7454bc0 
…towarefoundation#3501)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
@tkimura4 tkimura4 mentioned this pull request Jul 24, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@isamu-takagi isamu-takagi isamu-takagi approved these changes

@tkimura4 tkimura4 tkimura4 approved these changes

@taikitanaka3 taikitanaka3 taikitanaka3 approved these changes

@tkhmy tkhmy Awaiting requested review from tkhmy

@yabuta yabuta Awaiting requested review from yabuta

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@h-ohta h-ohta Awaiting requested review from h-ohta

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kosuke55 @taikitanaka3 @yukkysaito @takayuki5168 @isamu-takagi @tkimura4