-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): add goal planner #3454
Conversation
0611665
to
18a7d49
Compare
18a7d49
to
e5f58cc
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3454 +/- ##
==========================================
+ Coverage 13.72% 14.06% +0.33%
==========================================
Files 1395 1397 +2
Lines 97995 98024 +29
Branches 29096 29102 +6
==========================================
+ Hits 13451 13784 +333
+ Misses 70097 69574 -523
- Partials 14447 14666 +219
*This pull request uses carry forward flags. Click here to find out more.
... and 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
(plan to rename pull_over to goal_planner in other PR not to mix diff) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e5f58cc
to
c8b40d3
Compare
c8b40d3
to
f64ee85
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
3e6becd
to
05cb70f
Compare
* feat(behavior_path_planner): add goal planner Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix test Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
Make pull_over execute when the vehicle is approaching the goal. (within
minimum_request_length
)put goal in
road
2D Goal Pose
inroad
modifyPathForSmoothGoalConnection
(same as current lane following arrival path)2D Rough Goal Pose
inRoad
road
orroad_shoulder
with the select policy (e.g. parking left_side, right side)check
2D Goal Pose
and2D Rough Goal Pose
goal_planner_fixed-2023-04-19_00.12.24.mp4
check planning to the fixed goal within
minimum_request_length
goal_planner_fixed-2023-04-19_00.04.18.mp4
lane_change ->goal planner
goal_planner_fixed-2023-04-19_00.42.52.mp4
todo: need to execute lane_change and goal_planner wit new behavior path architecture to deal the situation the end of lane change is close to the goal. need
goal_planner_fixed-2023-04-19_00.44.25.mp4
put goal in
road_shoulder
: no change with this PRroad_shoulder
with the select policy (e.g. parking left_side, right side)Related links
#3223
Tests performed
psim
tier4 internal scenario test 1325/1330 -> 1325/1330
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.