-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fault injection): add find package to cmake #2973
fix(fault injection): add find package to cmake #2973
Conversation
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2973 +/- ##
=======================================
Coverage 11.98% 11.98%
=======================================
Files 1318 1318
Lines 91506 91504 -2
Branches 24240 24240
=======================================
Hits 10970 10970
+ Misses 69174 69172 -2
Partials 11362 11362
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Is it better to add |
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@wep21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
) (#297) * fix(fault injection) add find package to cmake * feat: add pluginlib to dependency --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
) (#298) * fix(fault injection) add find package to cmake * feat: add pluginlib to dependency --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
) (#297) * fix(fault injection) add find package to cmake * feat: add pluginlib to dependency --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
* fix(fault injection) add find package to cmake Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * feat: add pluginlib to dependency Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
) (#298) * fix(fault injection) add find package to cmake * feat: add pluginlib to dependency --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Description
I fixed build error of fault injection.
(I don't understand why fault_injection depends on pluginlib package.
There are many other packages to register plugins by rclcpp_components_register_node, but any other module without fault_injection do not cause error. )
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.