Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fault injection): add find package to cmake (#2973) #297

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Mar 2, 2023

Description

Hotfix to beta/v0.7.0-odaiba1
autowarefoundation#2973

fixed build error of fault injection.

Related links

autowarefoundation#2973

Tests performed

checked to success build

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

)

* fix(fault injection) add find package to cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: add pluginlib to dependency

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from KeisukeShima as a code owner March 2, 2023 04:12
@tkimura4 tkimura4 requested review from shmpwk and 1222-takeshi and removed request for KeisukeShima March 2, 2023 04:12
Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.7.0-odaiba1@cd65202). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                  Coverage Diff                   @@
##             beta/v0.7.0-odaiba1     #297   +/-   ##
======================================================
  Coverage                       ?   41.17%           
======================================================
  Files                          ?        4           
  Lines                          ?       85           
  Branches                       ?       47           
======================================================
  Hits                           ?       35           
  Misses                         ?       13           
  Partials                       ?       37           
Flag Coverage Δ
differential 41.17% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 merged commit ec86e6a into beta/v0.7.0-odaiba1 Mar 2, 2023
@tkimura4 tkimura4 deleted the fix/fault_injection_build branch March 2, 2023 05:40
tkimura4 added a commit that referenced this pull request Mar 3, 2023
) (#297)

* fix(fault injection) add find package to cmake



* feat: add pluginlib to dependency



---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants