Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_rviz_plugin): move footprint plugin to path #2971

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Mar 1, 2023

Description

Move footprint plugin into the path plugin in the tier4_planning_rviz_plugin directory.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (e7089d7) 11.98% compared to head (d4e3437) 11.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2971      +/-   ##
==========================================
- Coverage   11.98%   11.97%   -0.02%     
==========================================
  Files        1318     1318              
  Lines       91504    91641     +137     
  Branches    24240    24240              
==========================================
  Hits        10970    10970              
- Misses      69172    69309     +137     
  Partials    11362    11362              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.99% <ø> (+<0.01%) ⬆️ Carriedforward from e7089d7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ier4_planning_rviz_plugin/include/path/display.hpp 0.00% <ø> (ø)
...planning_rviz_plugin/include/path/display_base.hpp 0.00% <0.00%> (ø)
...on/tier4_planning_rviz_plugin/src/path/display.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit f76977a into main Mar 1, 2023
@purewater0901 purewater0901 deleted the feat/simplify-planning-plugin branch March 1, 2023 19:09
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…warefoundation#2971)

* feat(tier4_rviz_plugin): simplify tier4_planning_rviz_plugin

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
xianglunkai pushed a commit to xianglunkai/autoware.universe that referenced this pull request Apr 3, 2023
…n#2971)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants