-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): add new manager independent from behavior tree #2919
feat(behavior_path_planner): add new manager independent from behavior tree #2919
Conversation
0ff3482
to
f6aed5c
Compare
83ada32
to
8fe0ea6
Compare
8fe0ea6
to
71a844b
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
==========================================
- Coverage 11.52% 11.52% -0.01%
==========================================
Files 1314 1314
Lines 92819 92833 +14
Branches 25008 25018 +10
==========================================
Hits 10701 10701
- Misses 70875 70888 +13
- Partials 11243 11244 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
7a5791c
to
ce94908
Compare
planning/behavior_path_planner/include/behavior_path_planner/planner_manager.hpp
Show resolved
Hide resolved
...havior_path_planner/include/behavior_path_planner/scene_module_v2/scene_module_interface.hpp
Outdated
Show resolved
Hide resolved
...havior_path_planner/include/behavior_path_planner/scene_module_v2/scene_module_interface.hpp
Show resolved
Hide resolved
planning/behavior_path_planner/include/behavior_path_planner/planner_manager.hpp
Outdated
Show resolved
Hide resolved
ce94908
to
3fd2427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...ath_planner/include/behavior_path_planner/scene_module_v2/scene_module_manager_interface.hpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/include/behavior_path_planner/planner_manager.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…ture Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
35b8569
to
e8708a0
Compare
@rej55 @zulfaqar-azmi-t4 There is no critical regression. [TIER IV INTERNAL LINK] Baseline 811/814 |
…r tree (autowarefoundation#2919) * feat(data_manager): add member variable for new framework Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(utilities): add util function Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(behavior_path_planner): add framework that based on new architecture Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_path_planner): changeable framework by macro Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(behavior_path_planner): change framework in cmake Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_path_planner): fix cmake lint error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(planner_manager): rename functions Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(planner_manager): not use ModuleID Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(planner_manager): use lambda Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(planner_manager): reserve vector Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_path_planner): fix copyright Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> * fix(behavior_path_planner): fix copyright Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> * fix(behavior_path_planner): fix copyright Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
…r tree (autowarefoundation#2919) * feat(data_manager): add member variable for new framework Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(utilities): add util function Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(behavior_path_planner): add framework that based on new architecture Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_path_planner): changeable framework by macro Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(behavior_path_planner): change framework in cmake Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_path_planner): fix cmake lint error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(planner_manager): rename functions Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(planner_manager): not use ModuleID Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(planner_manager): use lambda Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(planner_manager): reserve vector Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_path_planner): fix copyright Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> * fix(behavior_path_planner): fix copyright Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> * fix(behavior_path_planner): fix copyright Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Description
⬇️ This must merge before this PR.
autowarefoundation/autoware_launch#218
In this PR, I add new manager that doesn't depend on behavior tree library. The manager is implemented based on the new architecture on this discussion.
NOTE
Related links
Tests performed
Evaluator
[TIER IV INTERNAL LINK] Baseline 811/814
[TIER IV INTERNAL LINK] This PR 812/814
Test by Psim
Please cherry-pick this commit to your
autoware_launch
or add following line tobehavior_path_planner.param.yaml
.If you want to use new manager, please set USE_BT to
FALSE
. For now, the manager can execute only lane following.simplescreenrecorder-2023-02-21_08.12.31.mp4
If you want to use conventional manager, please set USE_BT to
TRUE
.simplescreenrecorder-2023-02-21_09.24.17.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.