Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): use akima spline for xy only first #2800

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 2, 2023

Description

enable option to apply akima spline for xy only first when getting centerline from lanelet.
default: false

TODO

  • add a figure to compare when enabling and disabling akima spline.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 2, 2023
@takayuki5168 takayuki5168 changed the title Feat/use akima spline at first feat(behavior_path_planner): use akima spline for xy only first Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (1b35a6f) 12.76% compared to head (d52a4a3) 12.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2800      +/-   ##
==========================================
- Coverage   12.76%   12.76%   -0.01%     
==========================================
  Files        1222     1222              
  Lines       86234    86238       +4     
  Branches    24623    24627       +4     
==========================================
  Hits        11008    11008              
- Misses      63813    63817       +4     
  Partials    11413    11413              
Flag Coverage Δ *Carryforward flag
differential 5.56% <0.00%> (?)
total 12.76% <ø> (+<0.01%) ⬆️ Carriedforward from 1b35a6f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.13% <0.00%> (-0.01%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 7.69% <0.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 force-pushed the feat/use-akima-spline-at-first branch from 5f1fa34 to f843184 Compare February 6, 2023 16:20
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 6, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review February 6, 2023 16:24
@TakaHoribe
Copy link
Contributor

No large behavior change found, but looks ok.

Cubic
image

image

image

Akima

image

image

image

@tkimura4
Copy link
Contributor

tkimura4 commented Mar 3, 2023

@takayuki5168
Is it ready to merge?

@takayuki5168
Copy link
Contributor Author

@tkimura4 It seems I have to make a PR to awf/autoware_launch.
Do you wanna use this PR's function? I'm just curious about the reason you asked.

@tkimura4
Copy link
Contributor

tkimura4 commented Mar 3, 2023

@takayuki5168
It's just a part of repository maintenance.
I've not checked the contents of the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/use-akima-spline-at-first branch from c011e57 to d52a4a3 Compare March 10, 2023 08:33
@takayuki5168 takayuki5168 merged commit 5ec247b into autowarefoundation:main Mar 13, 2023
@takayuki5168 takayuki5168 deleted the feat/use-akima-spline-at-first branch March 13, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants