Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_control_launch): remove configs and move to autoware_launch #2544

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 20, 2022

Description

Move config to autoware_launch.

Two PRs should be merged at the same time.
autowarefoundation/autoware_launch#134

autowarefoundation/autoware_launch#66

Launch planning_simulator.launch.xml and verified that all the nodes in /control/* are launched successfully.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 20, 2022
@takayuki5168 takayuki5168 changed the title Feat/control/add component launch in autoware launch feat(tier4_control_launch): remove configs and move to autoware_launch Dec 20, 2022
@takayuki5168 takayuki5168 marked this pull request as ready for review December 20, 2022 11:47
@takayuki5168 takayuki5168 requested review from TakaHoribe and a team as code owners December 20, 2022 11:47
kminoda and others added 2 commits December 21, 2022 16:38
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@takayuki5168 takayuki5168 merged commit db178a9 into autowarefoundation:main Dec 21, 2022
@takayuki5168 takayuki5168 deleted the feat/control/add_component_launch_in_autoware_launch branch December 21, 2022 08:08
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Dec 22, 2022
autowarefoundation#2544)

* feat(tier4_control_launch): remove configs and move to autoware_launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_control_launch/README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: kminoda <koji.minoda@tier4.jp>
kminoda added a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
autowarefoundation#2544)

* feat(tier4_control_launch): remove configs and move to autoware_launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_control_launch/README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants