-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_control_launch): remove configs and move to autoware_launch #2544
Merged
takayuki5168
merged 4 commits into
autowarefoundation:main
from
tier4:feat/control/add_component_launch_in_autoware_launch
Dec 21, 2022
Merged
feat(tier4_control_launch): remove configs and move to autoware_launch #2544
takayuki5168
merged 4 commits into
autowarefoundation:main
from
tier4:feat/control/add_component_launch_in_autoware_launch
Dec 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
4 tasks
TakaHoribe
approved these changes
Dec 21, 2022
6 tasks
kminoda
reviewed
Dec 21, 2022
Signed-off-by: kminoda <koji.minoda@tier4.jp>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Dec 22, 2022
autowarefoundation#2544) * feat(tier4_control_launch): remove configs and move to autoware_launch Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update launch/tier4_control_launch/README.md Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: kminoda <koji.minoda@tier4.jp>
kminoda
added a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
autowarefoundation#2544) * feat(tier4_control_launch): remove configs and move to autoware_launch Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update launch/tier4_control_launch/README.md Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move config to autoware_launch.
Two PRs should be merged at the same time.
autowarefoundation/autoware_launch#134
autowarefoundation/autoware_launch#66
Launch planning_simulator.launch.xml and verified that all the nodes in /control/* are launched successfully.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.