Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): move config from autoware.universe for control #134

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 20, 2022

Description

Move config to autoware_launch.

Two PRs should be merged at the same time.
autowarefoundation/autoware.universe#2544

#66

Launch planning_simulator.launch.xml and verified that all the nodes in /control/* are launched successfully.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

@kminoda Could you approve this.

@takayuki5168 takayuki5168 requested a review from kminoda December 21, 2022 00:57
@takayuki5168
Copy link
Contributor Author

@kminoda Could you approve this.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda mentioned this pull request Dec 21, 2022
6 tasks
@takayuki5168 takayuki5168 merged commit c5afec1 into autowarefoundation:main Dec 21, 2022
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants