feat(tier4_system_launch): remove configs and move to autoware_launch #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
7 tasks
Signed-off-by: kminoda <koji.minoda@tier4.jp>
6 tasks
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kenji-miyake
approved these changes
Dec 21, 2022
|
@kminoda Could you fill the |
This was referenced Dec 21, 2022
4 tasks
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Dec 22, 2022
…autowarefoundation#2540) * feat(tier4_system_launch): remove configs and move to autoware_launch Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix readme * remove config Signed-off-by: kminoda <koji.minoda@tier4.jp> * minor fix Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix mistake Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix typo Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
added a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…autowarefoundation#2540) * feat(tier4_system_launch): remove configs and move to autoware_launch Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix readme * remove config Signed-off-by: kminoda <koji.minoda@tier4.jp> * minor fix Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix mistake Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix typo Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kminoda koji.minoda@tier4.jp
Description
Move config to autoware_launch.
Two PRs should be merged at the same time.
Related links
autowarefoundation/autoware_launch#66
Tests performed
Launch logging_simulator.launch.xml and verified that all the nodes in
/system/*are launched successfully.Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.