Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): move config from autoware.universe for system #130

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Dec 20, 2022

Description

Move config to autoware_launch.

Two PRs should be merged at the same time.

Related links

#66

Tests performed

Please refer to the PR in autoware.universe

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title Feat/system/add component launch in autoware launch feat(autoware_launch): move config to autoware_launch for system Dec 20, 2022
@kminoda kminoda marked this pull request as ready for review December 20, 2022 09:55
@kenji-miyake
Copy link
Contributor

feat(autoware_launch): move config to autoware_launch for system
Move config to autoware_launch.

[nits] I think it's better to say from autoware.universe for this PR.

@kminoda kminoda mentioned this pull request Dec 20, 2022
6 tasks
@kminoda kminoda changed the title feat(autoware_launch): move config to autoware_launch for system feat(autoware_launch): move config from autoware.universe for system Dec 20, 2022
@kminoda kminoda merged commit a4b7ccb into autowarefoundation:main Dec 21, 2022
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants