Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(simple_planning_simulator): refactor covariance index #1972

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 28, 2022

Signed-off-by: scepter914 scepter914@gmail.com

Description

Refactor covariance index in simple_planning_simulator package.
Change magic number to tier4_autoware_utils library (#1840).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 10.28% // Head: 10.36% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (b050e4a) compared to base (4e739ca).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
+ Coverage   10.28%   10.36%   +0.08%     
==========================================
  Files        1158     1158              
  Lines       82150    82273     +123     
  Branches    19120    19212      +92     
==========================================
+ Hits         8446     8526      +80     
- Misses      64563    64577      +14     
- Partials     9141     9170      +29     
Flag Coverage Δ *Carryforward flag
differential 57.65% <87.50%> (?)
total 10.26% <71.42%> (ø) Carriedforward from 8e86f0e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nning_simulator/simple_planning_simulator_core.cpp 46.20% <90.00%> (+7.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@scepter914 scepter914 merged commit 8dae2a2 into autowarefoundation:main Oct 1, 2022
@scepter914 scepter914 deleted the refactor/simple_planning_simulator_covariance_index branch October 1, 2022 06:17
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…arefoundation#1972)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…arefoundation#1972)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…arefoundation#1972)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants