-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_autoware_utils): add covariance util #1840
feat(tier4_autoware_utils): add covariance util #1840
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean. 🥕
To be a better pull request, would it be possible for you to link some related code in the description?
@kenji-miyake |
Codecov Report
@@ Coverage Diff @@
## main #1840 +/- ##
==========================================
- Coverage 10.44% 10.44% -0.01%
==========================================
Files 1221 1221
Lines 87728 87790 +62
Branches 20493 20532 +39
==========================================
+ Hits 9160 9166 +6
- Misses 69091 69146 +55
- Partials 9477 9478 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
) * feature(tier4_autoware_utils): add covariance util Signed-off-by: scepter914 <scepter914@gmail.com> * add include file Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * change enum to enum class Signed-off-by: scepter914 <scepter914@gmail.com> * add namespace Signed-off-by: scepter914 <scepter914@gmail.com> * change enum class to enum Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre commit Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
) * feature(tier4_autoware_utils): add covariance util Signed-off-by: scepter914 <scepter914@gmail.com> * add include file Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * change enum to enum class Signed-off-by: scepter914 <scepter914@gmail.com> * add namespace Signed-off-by: scepter914 <scepter914@gmail.com> * change enum class to enum Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre commit Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
) * feature(tier4_autoware_utils): add covariance util Signed-off-by: scepter914 <scepter914@gmail.com> * add include file Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * change enum to enum class Signed-off-by: scepter914 <scepter914@gmail.com> * add namespace Signed-off-by: scepter914 <scepter914@gmail.com> * change enum class to enum Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre commit Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
) * feature(tier4_autoware_utils): add covariance util Signed-off-by: scepter914 <scepter914@gmail.com> * add include file Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * change enum to enum class Signed-off-by: scepter914 <scepter914@gmail.com> * add namespace Signed-off-by: scepter914 <scepter914@gmail.com> * change enum class to enum Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre commit Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
) * feature(tier4_autoware_utils): add covariance util Signed-off-by: scepter914 <scepter914@gmail.com> * add include file Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * change enum to enum class Signed-off-by: scepter914 <scepter914@gmail.com> * add namespace Signed-off-by: scepter914 <scepter914@gmail.com> * change enum class to enum Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre commit Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
Description
Add msg_covariange for tier4_autoware_util to hundle index of covariance.
After this PR is merged, I would change enum definition in each package like radar_fusion and radar_tracks_msgs_converter to enum of autoware_util.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.