Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils): add covariance util #1840

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 12, 2022

Description

Add msg_covariange for tier4_autoware_util to hundle index of covariance.
After this PR is merged, I would change enum definition in each package like radar_fusion and radar_tracks_msgs_converter to enum of autoware_util.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 changed the title Feature/covarince util feature(tier4_autoware_utils): add covariance util Sep 12, 2022
@scepter914 scepter914 changed the title feature(tier4_autoware_utils): add covariance util feat(tier4_autoware_utils): add covariance util Sep 12, 2022
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean. 🥕
To be a better pull request, would it be possible for you to link some related code in the description?

@scepter914
Copy link
Contributor Author

@kenji-miyake
I add the link to related code 🙏

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1840 (aea40ab) into main (cb2552b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
- Coverage   10.44%   10.44%   -0.01%     
==========================================
  Files        1221     1221              
  Lines       87728    87790      +62     
  Branches    20493    20532      +39     
==========================================
+ Hits         9160     9166       +6     
- Misses      69091    69146      +55     
- Partials     9477     9478       +1     
Flag Coverage Δ *Carryforward flag
differential 11.89% <ø> (?)
total 10.42% <ø> (ø) Carriedforward from cb2552b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/behavior_velocity_planner/planner_data.hpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.70% <0.00%> (+0.28%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 83.01% <0.00%> (+9.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scepter914 scepter914 merged commit e28c169 into autowarefoundation:main Sep 12, 2022
@scepter914 scepter914 deleted the feature/covarince_util branch September 12, 2022 15:04
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
)

* feature(tier4_autoware_utils): add covariance util

Signed-off-by: scepter914 <scepter914@gmail.com>

* add include file

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum to enum class

Signed-off-by: scepter914 <scepter914@gmail.com>

* add namespace

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum class to enum

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre commit

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
)

* feature(tier4_autoware_utils): add covariance util

Signed-off-by: scepter914 <scepter914@gmail.com>

* add include file

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum to enum class

Signed-off-by: scepter914 <scepter914@gmail.com>

* add namespace

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum class to enum

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre commit

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
)

* feature(tier4_autoware_utils): add covariance util

Signed-off-by: scepter914 <scepter914@gmail.com>

* add include file

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum to enum class

Signed-off-by: scepter914 <scepter914@gmail.com>

* add namespace

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum class to enum

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre commit

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
)

* feature(tier4_autoware_utils): add covariance util

Signed-off-by: scepter914 <scepter914@gmail.com>

* add include file

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum to enum class

Signed-off-by: scepter914 <scepter914@gmail.com>

* add namespace

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum class to enum

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre commit

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 2, 2022
)

* feature(tier4_autoware_utils): add covariance util

Signed-off-by: scepter914 <scepter914@gmail.com>

* add include file

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum to enum class

Signed-off-by: scepter914 <scepter914@gmail.com>

* add namespace

Signed-off-by: scepter914 <scepter914@gmail.com>

* change enum class to enum

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre commit

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants