Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(imu_corrector): refactor covariance index #1878

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 15, 2022

Signed-off-by: scepter914 scepter914@gmail.com

Description

Refactor covariance magic number index.
Change magic number to tier4_autoware_util library merged in #1840.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 10.43% // Head: 10.43% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a4787ad) compared to base (ce3ecfb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   10.43%   10.43%   -0.01%     
==========================================
  Files        1232     1232              
  Lines       87941    87952      +11     
  Branches    20428    20428              
==========================================
  Hits         9174     9174              
- Misses      69433    69444      +11     
  Partials     9334     9334              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.41% <0.00%> (ø) Carriedforward from ce3ecfb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
sensing/imu_corrector/src/imu_corrector_core.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scepter914 scepter914 merged commit 794840d into autowarefoundation:main Sep 30, 2022
@scepter914 scepter914 deleted the refactor/imu_corrector_covariance branch September 30, 2022 01:33
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…n#1878)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…n#1878)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…n#1878)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants