Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing dependency #1891

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 16, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

As written in the title

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review September 16, 2022 03:53
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 10.12% // Head: 10.17% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (c6b32e2) compared to base (00e518e).
Patch has no changes to coverable lines.

❗ Current head c6b32e2 differs from pull request most recent head 492c10d. Consider uploading reports for the commit 492c10d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
+ Coverage   10.12%   10.17%   +0.05%     
==========================================
  Files        1251     1249       -2     
  Lines       90714    90357     -357     
  Branches    20499    20499              
==========================================
+ Hits         9187     9197      +10     
+ Misses      72014    71649     -365     
+ Partials     9513     9511       -2     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 10.16% <ø> (+0.05%) ⬆️ Carriedforward from fc48913

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/lib/src/trt_yolo.cpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/calibrator.hpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/cuda_utils.hpp 0.00% <0.00%> (ø)
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...tion/traffic_light_classifier/utils/trt_common.cpp 0.00% <0.00%> (ø)
...on/lidar_apollo_instance_segmentation/src/node.cpp 0.00% <0.00%> (ø)
...on/traffic_light_classifier/src/cnn_classifier.cpp 0.00% <0.00%> (ø)
...on/traffic_light_ssd_fine_detector/src/nodelet.cpp 0.00% <0.00%> (ø)
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yukkysaito yukkysaito self-requested a review September 16, 2022 05:59
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit d61e46a into autowarefoundation:main Sep 16, 2022
@takayuki5168 takayuki5168 deleted the fix/missing-dependency branch September 16, 2022 06:30
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
* fix: fix missing dependency

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* fix: fix missing dependency

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* fix: fix missing dependency

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
* fix: fix missing dependency

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants