-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_planning_launch): declare param path argument #1337
feat(tier4_planning_launch): declare param path argument #1337
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1337 +/- ##
========================================
- Coverage 9.53% 9.46% -0.08%
========================================
Files 1096 1088 -8
Lines 76578 70095 -6483
Branches 17222 16633 -589
========================================
- Hits 7304 6635 -669
+ Misses 62460 57150 -5310
+ Partials 6814 6310 -504
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
in near future, is it correct that the .universe and autoware_launcher configs will be synced?
Right. |
launch/tier4_planning_launch/launch/scenario_planning/scenario_planning.launch.xml
Show resolved
Hide resolved
* feat(tier4_planning_launch): declare param path argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
* feat(tier4_planning_launch): declare param path argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
* feat(tier4_planning_launch): declare param path argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
…ndation#1337) * feat(tier4_planning_launch): declare param path argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
* feat(tier4_planning_launch): declare param path argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update launch/tier4_planning_launch/launch/planning.launch.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
…checking (autowarefoundation#1337) * feat(control_validator): add min velocity for max distance deviation checking Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * chore(control_validator): remove debug logs Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> --------- Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
set tier4_planning_launch_param_path argument
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.