Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_launch): declare param path argument #1337

Merged
merged 3 commits into from
Jul 25, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 13, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

set tier4_planning_launch_param_path argument

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review July 20, 2022 08:24
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #1337 (a306e79) into main (6ebc85e) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head a306e79 differs from pull request most recent head 5a13fa3. Consider uploading reports for the commit 5a13fa3 to get more accurate results

@@           Coverage Diff            @@
##            main   #1337      +/-   ##
========================================
- Coverage   9.53%   9.46%   -0.08%     
========================================
  Files       1096    1088       -8     
  Lines      76578   70095    -6483     
  Branches   17222   16633     -589     
========================================
- Hits        7304    6635     -669     
+ Misses     62460   57150    -5310     
+ Partials    6814    6310     -504     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?) Carriedforward from 6004fad
total 9.46% <ø> (-0.06%) ⬇️ Carriedforward from 6004fad

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-71.43%) ⬇️
..._ad_api_msgs/msg/response_status__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
...d_api_msgs/srv/interface_version__type_support.cpp 0.00% <0.00%> (-54.55%) ⬇️
.../_autoware_ad_api_msgs_s.ep.rosidl_typesupport_c.c 0.00% <0.00%> (-47.46%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
...l/dds_fastrtps/interface_version__type_support.cpp 0.00% <0.00%> (-32.72%) ⬇️
...s/srv/detail/interface_version__type_support_c.cpp 0.00% <0.00%> (-31.00%) ⬇️
...py/autoware_ad_api_msgs/srv/_interface_version_s.c 0.00% <0.00%> (-29.63%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
... and 717 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebc85e...5a13fa3. Read the comment docs.

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
in near future, is it correct that the .universe and autoware_launcher configs will be synced?

@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Jul 20, 2022

in near future, is it correct that the .universe and autoware_launcher configs will be synced?

Right.
autoware_launch will have config, which is synced with tier4_*_launch in autoware.universe

@takayuki5168 takayuki5168 merged commit 34a74ab into autowarefoundation:main Jul 25, 2022
@takayuki5168 takayuki5168 deleted the feat/planning-param-path branch July 25, 2022 11:32
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(tier4_planning_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(tier4_planning_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(tier4_planning_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ndation#1337)

* feat(tier4_planning_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(tier4_planning_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update launch/tier4_planning_launch/launch/planning.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
TetsuKawa pushed a commit to TetsuKawa/autoware.universe that referenced this pull request Jun 27, 2024
…checking (autowarefoundation#1337)

* feat(control_validator): add min velocity for max distance deviation
checking

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* chore(control_validator): remove debug logs

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

---------

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants