Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tier4_localization_launch): declare param path argument #1404

Merged
merged 5 commits into from
Jul 26, 2022
Merged

feat(tier4_localization_launch): declare param path argument #1404

merged 5 commits into from
Jul 26, 2022

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 24, 2022 •
edited
Loading

Description

Set tier4_localization_launch_param_path argument

Related links

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda and others added 5 commits July 23, 2022 17:04
@kminoda
first commit
b1acfe5 
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
@kminoda
added arguments in each launch files
eb0489f 
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
@kminoda
finished implementation
a36137a 
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
@pre-commit-ci
ci(pre-commit): autofix
540c6a0
@kminoda
Merge branch 'main' into feat/localization-param-path
c98efad
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1404 (540c6a0) into main (123a472) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 540c6a0 differs from pull request most recent head c98efad. Consider uploading reports for the commit c98efad to get more accurate results

@@            Coverage Diff            @@
##             main   #1404      +/-   ##
=========================================
- Coverage   10.08%   9.94%   -0.15%     
=========================================
  Files        1117    1117              
  Lines       77287   77963     +676     
  Branches    17852   18114     +262     
=========================================
- Hits         7793    7752      -41     
- Misses      62145   62662     +517     
- Partials     7349    7549     +200
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 9.92% <ø> (-0.14%) ⬇️ Carriedforward from a36137a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...autoware_utils/test/src/geometry/test_geometry.cpp 40.69% <0.00%> (-1.56%) ⬇️
...include/tier4_autoware_utils/geometry/geometry.hpp 95.31% <0.00%> (-0.21%) ⬇️
...ion/crosswalk_traffic_light_estimator/src/node.cpp 0.00% <0.00%> (ø)
...ject_merger/src/object_association_merger/node.cpp 0.00% <0.00%> (ø)
...ction_by_tracker/src/detection_by_tracker_core.cpp 0.00% <0.00%> (ø)
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% <0.00%> (ø)
...ed_object_validation/src/object_lanelet_filter.cpp 0.00% <0.00%> (ø)
...ject_tracker/src/tracker/model/bicycle_tracker.cpp 0.00% <0.00%> (ø)
...ject_tracker/src/tracker/model/unknown_tracker.cpp 0.00% <0.00%> (ø)
...t_tracker/src/tracker/model/pedestrian_tracker.cpp 0.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a74ab...c98efad. Read the comment docs.

@kminoda kminoda changed the title Feat/localization param path feat(tier4_localization_launch): localization param path Jul 26, 2022
@kminoda kminoda changed the title feat(tier4_localization_launch): localization param path feat(tier4_localization_launch): declare param path argument Jul 26, 2022
@kminoda kminoda marked this pull request as ready for review July 26, 2022 00:02
takayuki5168
takayuki5168 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168
Copy link
Contributor

@kminoda
Please wait for @yukkysaito -kantoku's brief review just in case

yukkysaito
yukkysaito approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kminoda kminoda merged commit 4504ae1 into autowarefoundation:main Jul 26, 2022
@takayuki5168 takayuki5168 mentioned this pull request Jul 26, 2022
Closed
6 tasks
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 27, 2022
Merged
@kminoda kminoda mentioned this pull request Jul 27, 2022
Merged
7 tasks
@kminoda kminoda deleted the feat/localization-param-path branch September 15, 2022 07:56
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@kminoda @pre-commit-ci @boyali
feat(tier4_localization_launch): declare param path argument (tier4#1404
ea3ee8a 
)

* first commit

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* added arguments in each launch files

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* finished implementation

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@kminoda @pre-commit-ci @boyali
feat(tier4_localization_launch): declare param path argument (tier4#1404
4dff91e 
)

* first commit

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* added arguments in each launch files

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* finished implementation

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@kminoda @pre-commit-ci @boyali
feat(tier4_localization_launch): declare param path argument (tier4#1404
5292ec9 
)

* first commit

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* added arguments in each launch files

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* finished implementation

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@kminoda @pre-commit-ci
feat(tier4_localization_launch): declare param path argument (autowar…
850b01f 
…efoundation#1404)

* first commit

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* added arguments in each launch files

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* finished implementation

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@kminoda @pre-commit-ci @boyali
feat(tier4_localization_launch): declare param path argument (tier4#1404
606aaa8 
)

* first commit

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* added arguments in each launch files

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* finished implementation

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Aug 7, 2024
@takayuki5168
fix(controller): revival of dry steering (autowarefoundation#7903) (a…
ed46059 
…utowarefoundation#1404)

* Revert "fix(autoware_mpc_lateral_controller): delete the zero speed constraint (autowarefoundation#7673)"

This reverts commit 69258bd.

* dry steering



* add comments



* add minor fix and modify unit test for dry steering



---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kminoda @takayuki5168 @yukkysaito