Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(launch): fix missing changes for launch #10007

Merged
merged 3 commits into from
Jan 23, 2025
Merged

fix(launch): fix missing changes for launch #10007

merged 3 commits into from
Jan 23, 2025

Conversation

sasakisasaki
Copy link
Contributor

@sasakisasaki sasakisasaki commented Jan 22, 2025 •
edited
Loading

Description

This PR fixes the missing changes for the following PRs made by me. Sorry for bothering you due to the bug, ... .

How was this PR tested?

The tests are ongoing.
Tests for this PR is performed by using scenario evaluator.

Module level tests are performed in the following PRs (same as above).

I'm now investigating if there is no any missing fixes by using following command.

grep -R perception_online_evaluator ./
grep -R duplicated_node_checker ./

Notes for reviewers

None.

Effects on system behavior

Launching the Autoware nodes via tier4_perception_launch and tier4_system_launch will succeed.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sasakisasaki sasakisasaki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 22, 2025
@sasakisasaki sasakisasaki marked this pull request as ready for review January 23, 2025 00:08
@SakodaShintaro SakodaShintaro changed the title bug(launch): fix missing changes for launch fix(launch): fix missing changes for launch Jan 23, 2025
technolojin
technolojin approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit d4e488a into autowarefoundation:main Jan 23, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@technolojin technolojin technolojin approved these changes

@ito-san ito-san Awaiting requested review from ito-san ito-san is a code owner

@TetsuKawa TetsuKawa Awaiting requested review from TetsuKawa TetsuKawa is a code owner

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima KeisukeShima is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Software Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sasakisasaki @SakodaShintaro @technolojin @mitsudome-r