feat: apply autoware_ prefix for duplicated_node_checker

[sasakisasaki]

Description

This pull request addresses the issue of inconsistent naming by adding the autoware_ prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.

Related Links

• Prefix packages with autoware_ prefix and keep code in autoware namespace autoware#4569

How was this PR tested?

Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.

Executed Commands (which succeeded)

$ # Around 19:00 JST 21st Jan. 2025
$ vcs import src < autoware-nighty.repos    # Commented out autoware.universe repo
$ rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO
$ colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_duplicated_node_checker
$ source install/setup.bash 
$ ros2 launch autoware_duplicated_node_checker duplicated_node_checker.launch.xml 

• Directory Name

  • Add autoware_ as a prefix to the directory name.

• packages.xml

  • Add autoware_ to the name element.

• CMakeLists.txt

  • Change the project name to autoware_***.
  • Add autoware:: to PLUGIN.

• Header Files (.hpp)

  • Start #ifndef guards with AUTOWARE__.
  • Add autoware:: to namespace.

• Source Files (.cpp)

  • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.

• Launch Files

  • Add autoware_ before find-pkg-share.
  • Change node pkg="<pkgname>" to autoware_<pkgname>.

• Include

  • Add autoware folder as necessary and update include statements accordingly.
  • Check for impacts on other packages.

• Verification Points

  • Search find-pkg-share in autoware
  • Check README file (especially json schema)
  • Pay attention to complex cases like sensor_launch as seen in gnss_poser

Notes for Reviewers

None.

Interface Changes

None.

Effects on System Behavior

All the developers who were using duplicated_node_checker needs to modify their code. This is maybe kind of non quick-win task.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.46%. Comparing base (b132a88) to head (a68d480).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
..._node_checker/src/duplicated_node_checker_core.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #9970    +/-   ##
========================================
  Coverage   29.45%   29.46%            
========================================
  Files        1417     1426     +9     
  Lines      107418   107763   +345     
  Branches    42561    42784   +223     
========================================
+ Hits        31643    31752   +109     
- Misses      72698    72950   +252     
+ Partials     3077     3061    -16     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	29.47% <ø> (+0.01%)	⬆️	Carriedforward from 4a4980e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sasakisasaki]

Finally, I merged the latest main and ran the following command. It seems currently there are ongoing change on the main according to the following error message which is not related to this PR. Including the already performed tests and checks, we would be able to say this PR does not break the dependency on the main.

Command

$ rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO

Error Message that Indicates there is ongoing fixes on the main (not related to this PR's fixes)

ERROR: Rosdep experienced an error: Multiple packages found with the same name "autoware_ekf_localizer":
- core/autoware.core/localization/autoware_ekf_localizer
- universe/autoware.universe/localization/autoware_ekf_localizer
Please go to the rosdep page [1] and file a bug report with the stack trace below.
[1] : http://www.ros.org/wiki/rosdep