-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for OOB and Recovery code MFA challenges #442
Conversation
Hi @ejensen, thanks for this PR. We'll discuss this internally. |
@ejensen can you please provide more details about your use case? |
@Widcket We want to support Out Of Band (OOB) MFA Authenticators in addition to OTP MFA Authenticators. Adding API to support OOB MFA Authenticators allows clients to trigger the OOB challenges and authenticate with the responses detailed in Auth0's documentation: |
Hi @ejensen, can you please give me access to your fork so I can add a commit to see if that kickstarts the CI? |
@Widcket The fork is public and I gave you write access |
@ejensen Sorry, I hadn't accepted the invitation yet. My bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just missing tests for multifactorChallenge(mfaToken: String, types: [String]?, channel: String?, authenticatorId: String?)
. Make sure to test even the optional parameters.
Thanks @ejensen. |
Changes
This PR adds methods to start OOB MFA challenges and to login with OOB & recovery codes. Previously, the only supported MFA authenticator was OTP.
References
Testing
Checklist