Support OOB MFA challenges #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fea7ed0 to
0509e0f
Compare
|
@ejensen Auth0.swift 1.31.0 is out, this can be updated now. |
188935f to
7daf6b7
Compare
ejensen
commented
Feb 17, 2021
Widcket
reviewed
Feb 17, 2021
|
@Widcket I added unit tests. I also enabled code coverage reporting within Xcode so we don't have to wait for CodeCov process to report |
The code coverage is already being enabled when running in CI. |
|
Enabling code coverage within Xcode allows contributors to see both inline coverage and the overall coverage without waiting for the CodeCov CI job which only appears to run when the commit is made by an Auth0 team member.
|
Widcket
approved these changes
Feb 19, 2021
|
Since enabling code coverage within Xcode requires to modify the CI script, I'll raise that in a new PR. |
Merged
|
This is now out in v2.22.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for OOB MFA challenges by calling the
/mfa/challengeendpoint when the MFA screen is shown. It uses the correctgrant_typefor the type of MFA challenge that was triggered. Previously, only the OTP MFA authenticator was supported. Now SMS/Voice/Email can also be used.References
Testing
Checklist