Added support for boolean claims #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this wasn't added for specific reasons or just an oversight. I have been using it in my fork and was wondering if it could make it to upstream.
|
Hi @kaishin, could you please add tests? |
Widcket
reviewed
Feb 1, 2021
| if let string = self.string { | ||
| double = Double(string) | ||
| } else { | ||
| } else if self.boolean == nil { |
There was a problem hiding this comment.
Otherwise the boolean converts as 0 or 1.
This was referenced Feb 1, 2021
lbalmaceda
approved these changes
Feb 2, 2021
Merged
|
Sorry for being unresponsive. Great work getting this merged! I appreciate it. |
kaishin
added a commit
to kaishin/jwt-decode
that referenced
this pull request
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this wasn't added for specific reasons or just an oversight. I have been using it in my fork and was wondering if it could make it to upstream.
Changes
Please describe both what is changing and why this is important. Include:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist