Updated Quick and Nimble #421
Conversation
|
So this PR will be a breaking change in that Carthage at the very least will no longer work in Xcode versions below 12? The moment we need to remove a CI test case we really need to be and are we communicating this clearly? Better to over-communicate than under. Does this min Xcode support now shift as well to 12 in README? Although this is necessary for Xcode 12 and Carthage. This really needs to be called out explicitly in the README that for Xcode <12 use Minor X for Xcode >=12 this minor is needed. Presumably, all of the QS Samples need to be updated as well then? |
|
@cocojoe Quick and Nimble are dropping support for Xcode < 11.4, so it would still work with Xcode 11.4+. So no, the minimum supported Xcode does not shift to 12. |
|
@cocojoe besides, the README currently states that the supported Xcode versions are 11.x. So the only thing that would actually change is that to use Carthage you would have to use Xcode 11.4+, instead of 11.0-11.3. And that just because the library uses Carthage to manage its own dependencies. The Podspec does not even mention Quick and Nimble. |
|
This needs a heavy call out and clear context, if the minimum listed is 11.x then give the circumstances I think it's okay. We just need to be very explicit to avoid any potential confusion. |
|
Correction, it says "Xcode 10.x / 11.x" However, you can't submit apps to the AppStore that were built with Xcode 10.x anymore, so it's effectively EOL'd. |
|
And with the current major being 4 years old, Xcode 10 is not the first Xcode version to stop being supported by this library, I suppose. |
|
@cocojoe I've added a notice to the README. |
| [Behaviour changes in iOS 13](https://github.com/auth0/Auth0.swift/pull/297) related to Web Authentication require that developers using Xcode 11 with this library **must** compile using Swift 5.x. This *should* be the default setting applied when updating, unless it has been manually set. However, we recommend checking that this value is set correctly. | ||
| ## Important Notices | ||
| - [The latest majors of Quick and Nimble](https://github.com/auth0/Auth0.swift/pull/421) require that developers using Carthage **must** use Xcode 11.4+ only, starting from Auth0.swift [1.29.0](https://github.com/auth0/Auth0.swift/releases/tag/1.29.0). | ||
| - [Behaviour changes in iOS 13](https://github.com/auth0/Auth0.swift/pull/297) related to Web Authentication require that developers using Xcode 11 with this library **must** compile using Swift 5.x. This *should* be the default setting applied when updating, unless it has been manually set. However, we recommend checking that this value is set correctly. |
There was a problem hiding this comment.
Should we create a historical notices section and move this part to then? iOS 13 feels way less relevant now.
Changes
This PR updates the test dependencies Quick and Nimble to the latest majors, making it possible to test Auth0.swift with Xcode 12. This update will also allow to start addressing the compilation issues on BigSur.
The new majors of Quick and Nimble no longer support Swift versions < 5.2. This means that the tests can no longer be run on Xcode versions < 11.4. The CircleCI config has been updated accordingly.
Testing
Checklist