Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macCatalyst support #396

Closed
piercifani opened this issue Jul 7, 2020 · 9 comments · Fixed by #425
Closed

macCatalyst support #396

piercifani opened this issue Jul 7, 2020 · 9 comments · Fixed by #425
Assignees
Labels
bug This points to a verified bug in the code needs investigation An issue that has more questions to answer or otherwise needs work to fully understand the issue

Comments

@piercifani
Copy link

Describe the problem you'd like to have solved

We're building a macCatalyst version of our application, but some of the symbols used inside Auth0 are not available for macCatalyst. Specifically, SFAuthenticationError symbols are deprecated since iOS 13 and they should be migrated to ASWebAuthenticationSessionErrorCode.

Describe the ideal solution

macCatalyst should be a supported platform, specially since Apple Silicon based Macs are right around the corner and run iOS apps as is. Intel based Macs should also get this treatment with Catalyst.

Alternatives and current work-arounds

Remove Auth0 from our codebase and build login manually.

Additional context

Auth0 is integrated with CocoaPods

@cocojoe
Copy link
Member

cocojoe commented Jul 10, 2020

Thanks @piercifani we are evaluating this internally 👍 I'll leave this open for now.

@cocojoe cocojoe added enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature needs investigation An issue that has more questions to answer or otherwise needs work to fully understand the issue labels Jul 10, 2020
@Widcket
Copy link
Contributor

Widcket commented Aug 11, 2020

Hi @piercifani, I tested with a sample app and it compiles successfully with Xcode Version 11.6 (11E708). SimpleKeychain compiles with a couple of warnings, though, and those will be addressed.

@Widcket Widcket added question waiting for customer This issue is waiting for a response from the issue or PR author and removed enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature needs investigation An issue that has more questions to answer or otherwise needs work to fully understand the issue question labels Aug 11, 2020
@Widcket
Copy link
Contributor

Widcket commented Aug 12, 2020

Auth0.swift also produces a few Catalyst-related compiler warnings, and we'll be addressing these as well.

Screen Shot 2020-08-11 at 21 30 50

@piercifani
Copy link
Author

Hey!

I just updated to Auth0 version 1.27.0 and I'm still getting this error when compiling:

image

@Widcket
Copy link
Contributor

Widcket commented Aug 19, 2020

@piercifani are you using Xcode 12 and/or macOS Big Sur?

@piercifani
Copy link
Author

Yes, latest beta 5 in Big Sur

@Widcket
Copy link
Contributor

Widcket commented Aug 25, 2020

Thanks, we'll dig more into this.

@Widcket Widcket added needs investigation An issue that has more questions to answer or otherwise needs work to fully understand the issue and removed waiting for customer This issue is waiting for a response from the issue or PR author labels Aug 25, 2020
@Widcket Widcket added the bug This points to a verified bug in the code label Sep 10, 2020
@piercifani
Copy link
Author

The issue is that SFAuthenticationSession is not available on Catalyst, so you have to use ASWebAuthenticationSession. Thankfully it's just a rename

@Widcket
Copy link
Contributor

Widcket commented Oct 23, 2020

This is now fixed in 1.30.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code needs investigation An issue that has more questions to answer or otherwise needs work to fully understand the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants