Updated Quick and Nimble #114
Conversation
|
@lbalmaceda can you please update the branch protection settings? The only CircleCI jobs that should be marked as required are build-and-test-iOS-swift-5_2, build-and-test-macOS-swift-5_2, build-and-test-tvOS-swift-5_2 as the others have been removed. |
Done |
README.md
Outdated
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Fauth0%2FJWTDecode.swift?ref=badge_shield) | ||
|
|
||
| This library will help you check [JWT](https://jwt.io/) payload | ||
|
|
||
| > This library doesn't validate the token, any well formed JWT can be decoded from Base64Url. | ||
|
|
||
| ## Important Notices | ||
| - [The latest majors of Quick and Nimble](https://github.com/auth0/JWTDecode.swift/pull/114) require that developers using Carthage **must** use Xcode 11.4+ only, starting from JWTDecode.swift [2.5.0](https://github.com/auth0/JWTDecode.swift/releases/tag/2.5.0). |
There was a problem hiding this comment.
I would update requirements to match 11.4+, give we're not testing on anything less now, can't say for sure that it works.
There was a problem hiding this comment.
I removed the notice and updated the Xcode requirements to 11.4+. One is not compatible with the other because the notice says "developers using Carthage", while the requirements are for everyone. From the PoV of an external observer, we would be warning Carthage developers about something that is completely moot because the requirements themselves say the library needs Xcode 11.4+.
There was a problem hiding this comment.
That is, the updated requirements supersede the notice. If we'd prefer to use the notice, then we should keep the old requirements.
There was a problem hiding this comment.
I'm pointing to this PR in order to use JWTDecode.swift in a Xcode 12 project, is going to be merged 🙂?
…e.swift into chore/update-dependencies
* Update Quick and Nimble * Add notice to README * Update gems * Add Circle CI fastlane action * Add Carthage flags * Update Scanfile values * Remove store-results seteps for macOS and tvOS * Disable automatic brew cleanup * Add BUNDLE_PATH env variable * Remove overriden Scan config * Update README.md * Use upToNextMajor for SPM dependencies * Remove comment * Add .git to repo paths
Changes
This PR updates the test dependencies Quick and Nimble to the latest majors, making it possible to test JWTDecode.swift with Xcode 12.
The new majors of Quick and Nimble no longer support Swift versions < 5.2. This means that the tests can no longer be run on Xcode versions < 11.4. The CircleCI config has been updated accordingly.
The requirements section in the README has been updated as well.
References
Same changes in Auth0.swift: auth0/Auth0.swift#421
Same changes in SimpleKeychain: auth0/SimpleKeychain#97
Testing
Checklist