Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error message from /servers/details when no query string parameter given #6800

Closed
ocket8888 opened this issue Apr 27, 2022 · 0 comments · Fixed by #6818
Closed

Incorrect error message from /servers/details when no query string parameter given #6800

ocket8888 opened this issue Apr 27, 2022 · 0 comments · Fixed by #6818
Labels
bug something isn't working as intended low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops

Comments

@ocket8888
Copy link
Contributor

This Bug Report affects these Traffic Control components:

  • Traffic Ops

Current behavior:

/servers/details requires one of the query string parameters hostName or physLocationID be specified, but if neither are, the error message says:

{
	"alerts": [
		{
			"text": "Missing required fields: 'hostname' or 'physLocationID'",
			"level": "error"
		}
	]
}

Expected behavior:

The error message should name the actual required query string parameter: hostName not hostname.

Steps to reproduce:

  1. toget -kp '/servers/details?hostname=anything'
@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one low difficulty the estimated level of effort to resolve this issue is low labels Apr 27, 2022
@rimashah25 rimashah25 mentioned this issue May 10, 2022
Merged
4 tasks
@ocket8888 ocket8888 mentioned this issue May 10, 2022
Merged
4 tasks
ocket8888 added a commit to ocket8888/trafficcontrol that referenced this issue May 13, 2022
@ocket8888
Add deprecation notices, remove v4 handling, fix apache#6800
9e2f2e2
shamrickus pushed a commit that referenced this issue May 17, 2022
@ocket8888
Remove /servers/details from APIv4 (#6819)
b9cdfd5 
* Add deprecation notices, remove v4 handling, fix #6800

* Update documentation - add deprecation notices to v3, remove from v4

* Update clients - remove from v4, add deprecation notices to v3

* Update CHANGELOG

* fix unable to get server details by hostname if physloc not also provided

* Fix embedded 'response' object
@asf-ci asf-ci mentioned this issue Jun 1, 2022
Merged
4 tasks
zrhoffman pushed a commit to zrhoffman/trafficcontrol that referenced this issue Oct 2, 2022
@ocket8888
Remove /servers/details from APIv4 (apache#6819)
0525e7c 
* Add deprecation notices, remove v4 handling, fix apache#6800

* Update documentation - add deprecation notices to v3, remove from v4

* Update clients - remove from v4, add deprecation notices to v3

* Update CHANGELOG

* fix unable to get server details by hostname if physloc not also provided

* Fix embedded 'response' object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working as intended low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed error message in server/details with respect to query params. rimashah25/trafficcontrol
1 participant
@ocket8888