-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /servers/details
from APIv4
#6819
Remove /servers/details
from APIv4
#6819
Conversation
f30d4cb
to
aa7194b
Compare
aa7194b
to
b524bc8
Compare
Curl cmd to servers/details API v3.0 with query param Curl cmd to servers/details API v3.0 with query param Curl cmd to servers/details API v4.0 show appropriate error. |
APIv3 integration are failing on local as well as github. |
Is this valid? |
It was, it's just that it's already been fixed. I can remove it from the description, though, since it's not technically true anymore. |
v2 tests are failing too, but I didn't want to fix those because I was hoping the PR to remove APIv2 would be opened soon and I could just rely on that instead of fixing anything. I'm re-running v3 because they tend to be flaky, but if they still fail I'll probably just fix both. |
I am ok with v2 failure since they will be removed soon. But v3 is still failing, so we need to fix that before we merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add deprecation notices, remove v4 handling, fix apache#6800 * Update documentation - add deprecation notices to v3, remove from v4 * Update clients - remove from v4, add deprecation notices to v3 * Update CHANGELOG * fix unable to get server details by hostname if physloc not also provided * Fix embedded 'response' object
This PR removes
/servers/details
from version 4.0 of the API, and adds deprecation notices to v3.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the tests still pass, verify endpoint doesn't exist in v4, returns deprecation alerts in lower versions
PR submission checklist