Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error message in server/details with respect to query params. #6818

Merged

Conversation

rimashah25
Copy link
Contributor

Closes: #6800


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Curl /servers/details?hostname=foo and see error message

{
	"alerts": [{
		"text": "missing required fields: 'hostName' or 'physLocationID'",
		"level": "error"
	}]
}

If this is a bugfix, which Traffic Control versions contained the bug?

6.1.0

PR submission checklist

Copy link
Contributor

@ericholguin ericholguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GET /server/details without any parameters:

{
    "alerts": [
        {
            "text": "missing required fields: 'hostName' or 'physLocationID'",
            "level": "error"
        }
    ]
}

@ocket8888
Copy link
Contributor

I'm re-running the API tests

@ocket8888 ocket8888 merged commit 2900f5f into apache:master May 11, 2022
@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one labels May 11, 2022
@rimashah25 rimashah25 deleted the bugfix/error-message-server-details branch May 23, 2022 19:51
zrhoffman pushed a commit to zrhoffman/trafficcontrol that referenced this pull request Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error message from /servers/details when no query string parameter given
3 participants