Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TO API uses non-RFC3339 date/time strings #5911

Closed
ocket8888 opened this issue Jun 3, 2021 · 3 comments · Fixed by #7806
Closed

TO API uses non-RFC3339 date/time strings #5911

ocket8888 opened this issue Jun 3, 2021 · 3 comments · Fixed by #7806
Labels
high difficulty the estimated level of effort to resolve this issue is high medium impact impacts a significant portion of a CDN, or has the potential to do so tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Milestone
8.0.0

Comments

@ocket8888
Copy link
Contributor

I'm submitting a ...

  • other

Traffic Control components affected ...

  • Traffic Ops
  • unknown

Current behavior:

Traffic Ops API responses frequently return our custom format for date/times: YYYY-MM-DD hh:mm:ss-ZZ ("2006-01-02 15:04:05-07" is the actual Go format string).

Expected behavior:

The Traffic Ops API (in the latest API version, where the behavior is breakable) should respond with RFC3339-format date strings.

Minimal reproduction of the problem with instructions:

Make most any TO API request.
@ocket8888 ocket8888 added the tech debt rework due to choosing easy/limited solution label Jun 3, 2021
@ocket8888
Copy link
Contributor Author

In practice we use UTC everywhere of which I know, but this time format is not capable of representing all time zones, should that ever come up.

@mitchell852 mitchell852 added the Traffic Ops related to Traffic Ops label Jun 7, 2021
@ocket8888 ocket8888 added high difficulty the estimated level of effort to resolve this issue is high medium impact impacts a significant portion of a CDN, or has the potential to do so labels Dec 1, 2021
jagan-parthiban added a commit to jagan-parthiban/trafficcontrol that referenced this issue Mar 17, 2023
@jagan-parthiban
This fixes service_category apis to respond with RFC3339 date/time st…
ab5aa09 
…rings. Issue: apache#5911
This was referenced Mar 17, 2023
Merged
Closed
ocket8888 pushed a commit that referenced this issue Apr 19, 2023
@jagan-parthiban
Fixes service_category apis to respond with RFC3339 date/time Format (#…
664c2d5 
…7408)

* This fixes service_category apis to respond with RFC3339 date/time strings. Issue: #5911

* This fixes service_category apis to respond with RFC3339 date/time strings.

* This fixes service_category apis to respond with RFC3339 date/time strings. This commit removed new struct TimeRFC3339 and uses time.Time instead

* This commit removed new struct TimeRFC3339 and uses time.Time instead

* #7413

Removing dependency of service catergory on generic cruder for V5 version

* Corrected Error messages statement

* Added Doc content for RFC 3339 Date/Time Format and updated service category docs.

* Updated Http Get operations for Service Category V5 to handle If-Modified-Since request HTTP header

* Added Unit Test Cases for V5 service_category functions

* Updated comments for the V5 service category functions.

* Updated CHANGELOG.md

* Added Unit test for db_helpers.go

* Addressed Code review from the PR.

* Addressed Code review from the PR.

* Addressed Code review from the PR.

* Addressed Code review from the PR.
@jagan-parthiban jagan-parthiban mentioned this issue Apr 26, 2023
Closed
This was referenced May 3, 2023
Merged
Closed
This was referenced May 26, 2023
Closed
Merged
This was referenced Jun 9, 2023
Closed
Merged
@gbkannan89 gbkannan89 mentioned this issue Jun 12, 2023
Merged
4 tasks
@rimashah25 rimashah25 mentioned this issue Jun 13, 2023
Merged
4 tasks
@gbkannan89 gbkannan89 mentioned this issue Jun 23, 2023
Merged
4 tasks
This was referenced Jul 3, 2023
Closed
Merged
This was referenced Jul 11, 2023
Closed
Merged
@rimashah25 rimashah25 added this to the 8.0.0 milestone Jul 18, 2023
@gbkannan89 gbkannan89 mentioned this issue Jul 18, 2023
Merged
4 tasks
@gbkannan89 gbkannan89 mentioned this issue Aug 4, 2023
Merged
4 tasks
@jagan-parthiban jagan-parthiban mentioned this issue Aug 8, 2023
Closed
@zrhoffman zrhoffman mentioned this issue Aug 9, 2023
Closed
@jagan-parthiban jagan-parthiban mentioned this issue Aug 10, 2023
Merged
4 tasks
@ocket8888 ocket8888 mentioned this issue Aug 15, 2023
Merged
4 tasks
@gbkannan89 gbkannan89 mentioned this issue Aug 18, 2023
Merged
4 tasks
@rimashah25 rimashah25 mentioned this issue Aug 21, 2023
Merged
4 tasks
This was referenced Aug 22, 2023
Closed
Merged
@zrhoffman zrhoffman mentioned this issue Aug 25, 2023
Closed
@jagan-parthiban jagan-parthiban mentioned this issue Aug 25, 2023
Merged
4 tasks
@rimashah25 rimashah25 mentioned this issue Aug 28, 2023
Merged
4 tasks
This was referenced Aug 30, 2023
Closed
Merged
@rimashah25
Copy link
Contributor

All APIs that were affected by implementing RFC3339 have been updated.

@ocket8888 ocket8888 mentioned this issue Sep 12, 2023
Closed
@ocket8888
Copy link
Contributor Author

found another

@ocket8888 ocket8888 reopened this Sep 12, 2023
@ocket8888 ocket8888 mentioned this issue Sep 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high difficulty the estimated level of effort to resolve this issue is high medium impact impacts a significant portion of a CDN, or has the potential to do so tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
8.0.0
3 participants
@mitchell852 @ocket8888 @rimashah25