Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To origin rfc3339 #7733

Merged
merged 44 commits into from
Sep 5, 2023
Merged

To origin rfc3339 #7733

merged 44 commits into from
Sep 5, 2023

Conversation

gbkannan89
Copy link
Contributor

@gbkannan89 gbkannan89 commented Aug 18, 2023

Related: #5911


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Curl all Origin v5 REST calls (GET, CREATE, UPDATE, DELETE) and ensure you are getting RFC3339 date-time ( eg: lastUpdated : "2023-05-25T15:59:33.7096-06:00" )

If this is a bugfix, which Traffic Control versions contained the bug?

  • 5.0.x

PR submission checklist

@gbkannan89 gbkannan89 marked this pull request as ready for review August 18, 2023 08:44
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #7733 (2e1a252) into master (75ec56f) will decrease coverage by 33.27%.
Report is 104 commits behind head on master.
The diff coverage is 58.77%.

@@              Coverage Diff              @@
##             master    #7733       +/-   ##
=============================================
- Coverage     65.05%   31.79%   -33.27%     
  Complexity       98       98               
=============================================
  Files           314      714      +400     
  Lines         12365    82338    +69973     
  Branches        907      965       +58     
=============================================
+ Hits           8044    26177    +18133     
- Misses         3968    54015    +50047     
- Partials        353     2146     +1793     
Flag Coverage Δ
golib_unit 53.64% <58.66%> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.96% <2.80%> (?)
traffic_monitor_unit 26.33% <0.00%> (?)
traffic_ops_integration 69.42% <ø> (+<0.01%) ⬆️
traffic_ops_unit 21.50% <ø> (?)
traffic_portal_v2 74.34% <74.02%> (+0.56%) ⬆️
traffic_stats_unit 10.78% <ø> (?)
unit_tests 29.09% <58.77%> (-44.69%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-check-refs/t3c-check-refs.go 1.78% <0.00%> (ø)
cache-config/t3c-generate/cfgfile/varnish.go 0.00% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.81% <0.00%> (-0.08%) ⬇️
cache-config/t3c-generate/t3c-generate.go 0.00% <ø> (ø)
experimental/traffic-portal/src/app/api/index.ts 100.00% <ø> (ø)
...mental/traffic-portal/src/app/api/testing/index.ts 100.00% <ø> (ø)
...perimental/traffic-portal/src/app/app.ui.module.ts 100.00% <ø> (ø)
...tatuses/statuses-table/statuses-table.component.ts 82.35% <ø> (ø)
... and 88 more

... and 367 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 self-assigned this Aug 23, 2023
@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one improvement The functionality exists but it could be improved in some way. tech debt rework due to choosing easy/limited solution and removed improvement The functionality exists but it could be improved in some way. labels Aug 23, 2023
docs/source/api/v5/origins.rst Outdated Show resolved Hide resolved
lib/go-tc/origins.go Outdated Show resolved Hide resolved
lib/go-tc/origins.go Outdated Show resolved Hide resolved
lib/go-tc/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
@gbkannan89 gbkannan89 requested a review from ocket8888 August 24, 2023 17:47
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v5/origins_test.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/v5-client/origin.go Outdated Show resolved Hide resolved
traffic_ops/v5-client/origin.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v5/origins_test.go Outdated Show resolved Hide resolved
@gbkannan89 gbkannan89 requested a review from ocket8888 August 29, 2023 17:03
lib/go-tc/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/origin/origins.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v5/origins_test.go Outdated Show resolved Hide resolved
@gbkannan89 gbkannan89 requested a review from ocket8888 August 29, 2023 22:29
@gbkannan89 gbkannan89 requested a review from ocket8888 August 31, 2023 15:41
@gbkannan89 gbkannan89 requested a review from ocket8888 August 31, 2023 17:06
@gbkannan89 gbkannan89 requested a review from ocket8888 August 31, 2023 22:13
@ocket8888 ocket8888 merged commit 8ce828a into apache:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants