-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ProfileParameters V5 apis to respond with RFC3339 date/time Format #7738
Fixes ProfileParameters V5 apis to respond with RFC3339 date/time Format #7738
Conversation
6329dfb
to
2814792
Compare
Codecov Report
@@ Coverage Diff @@
## master #7738 +/- ##
=============================================
- Coverage 65.05% 32.18% -32.87%
Complexity 98 98
=============================================
Files 314 710 +396
Lines 12365 80080 +67715
Branches 907 965 +58
=============================================
+ Hits 8044 25777 +17733
- Misses 3968 52151 +48183
- Partials 353 2152 +1799
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 357 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested the changes on local and RFC 3339 format is only seen for v5 API calls.
Closes: #7737
Related: #5911
What is the best way to verify this PR?
Make Api calls to Parameter 5.0
ProfileParameters to Use RFC3339 Format
PR submission checklist