Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ProfileParameters V5 apis to respond with RFC3339 date/time Format #7738

Merged

Conversation

jagan-parthiban
Copy link
Contributor

Closes: #7737
Related: #5911


  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Make Api calls to Parameter 5.0

ProfileParameters to Use RFC3339 Format

{
	"response": [
		{
			"lastUpdated": "2023-08-22T09:51:03.556698+05:30",
			"profile": "test2",
			"parameter": 1070
		},
		{
			"lastUpdated": "2023-08-22T10:33:23.249862+05:30",
			"profile": "test2",
			"parameter": 1071
		}
       ]
}

PR submission checklist

@jagan-parthiban jagan-parthiban added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution improvement The functionality exists but it could be improved in some way. labels Aug 22, 2023
@jagan-parthiban jagan-parthiban force-pushed the improve/rfc3339-profileparameter branch from 6329dfb to 2814792 Compare August 22, 2023 17:11
@jagan-parthiban jagan-parthiban marked this pull request as ready for review August 22, 2023 17:15
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #7738 (cf084ed) into master (75ec56f) will decrease coverage by 32.87%.
Report is 78 commits behind head on master.
The diff coverage is 29.96%.

@@              Coverage Diff              @@
##             master    #7738       +/-   ##
=============================================
- Coverage     65.05%   32.18%   -32.87%     
  Complexity       98       98               
=============================================
  Files           314      710      +396     
  Lines         12365    80080    +67715     
  Branches        907      965       +58     
=============================================
+ Hits           8044    25777    +17733     
- Misses         3968    52151    +48183     
- Partials        353     2152     +1799     
Flag Coverage Δ
golib_unit 52.62% <37.76%> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.99% <3.31%> (?)
traffic_monitor_unit 26.33% <0.00%> (?)
traffic_ops_integration 69.39% <ø> (-0.03%) ⬇️
traffic_ops_unit 22.22% <3.95%> (?)
traffic_portal_v2 74.38% <74.17%> (+0.59%) ⬆️
traffic_stats_unit 10.76% <ø> (?)
unit_tests 29.45% <29.96%> (-44.33%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.52% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-check-refs/t3c-check-refs.go 1.78% <0.00%> (ø)
cache-config/t3c-generate/cfgfile/varnish.go 0.00% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.81% <0.00%> (-0.08%) ⬇️
cache-config/t3c-generate/t3c-generate.go 0.00% <ø> (ø)
experimental/traffic-portal/src/app/api/index.ts 100.00% <ø> (ø)
...mental/traffic-portal/src/app/api/testing/index.ts 100.00% <ø> (ø)
...perimental/traffic-portal/src/app/app.ui.module.ts 100.00% <ø> (ø)
...tatuses/statuses-table/statuses-table.component.ts 82.35% <ø> (ø)
... and 93 more

... and 357 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

}

query := selectQuery() + where + orderBy + pagination
rows, err := tx.NamedQuery(query, queryValues)

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query depends on a [user-provided value](1).
Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the changes on local and RFC 3339 format is only seen for v5 API calls.

@rimashah25 rimashah25 merged commit 7ce9214 into apache:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProfileParameters in TO API uses non-RFC3339 date/time strings
2 participants