Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance (pagination and search) of TP's tables #4354

Closed
4 of 16 tasks
mitchell852 opened this issue Jan 29, 2020 · 2 comments · Fixed by #4769
Closed
4 of 16 tasks

Improve performance (pagination and search) of TP's tables #4354

mitchell852 opened this issue Jan 29, 2020 · 2 comments · Fixed by #4769
Assignees
Labels
improvement The functionality exists but it could be improved in some way. new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1

Comments

@mitchell852
Copy link
Member

mitchell852 commented Jan 29, 2020

I'm submitting a ...

  • bug report
  • new feature / enhancement request
  • improvement request (usability, performance, tech debt, etc.)
  • other

This would be an improvement for TP and a potential enhancement to the TO API.

Traffic Control components affected ...

  • CDN in a Box
  • Documentation
  • Grove
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • unknown

Current behavior:

Currently TP fetches ALL records (i.e. servers, delivery services, etc) from the TO API and does the pagination and search on the client-side in the browser. As the number of records grow, the amount of time required by jquery datatables to render the TP tables and the amount of browser memory required to do this grows. Eventually that memory may run out and TP tables may become unusable.

Expected / new behavior:

2 possible solutions:

  1. Implement a better table library
  2. push the pagination and search to the server-side (the API) and leveraging some of the existing as well as some new features of the API.

Minimal reproduction of the problem with instructions:

Create thousands of records (i.e. servers) and navigate to https://tp.domain.net/#!/servers and watch how long it takes for the table to render.

@mitchell852 mitchell852 added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 improvement The functionality exists but it could be improved in some way. labels Jan 29, 2020
@mitchell852 mitchell852 changed the title Server-side processing of TP tables Server-side processing (pagination and search) of TP tables Jan 29, 2020
@mitchell852 mitchell852 changed the title Server-side processing (pagination and search) of TP tables Improve performance (pagination and search) of TP tables Jun 9, 2020
@mitchell852 mitchell852 changed the title Improve performance (pagination and search) of TP tables Improve performance (pagination and search) of TP's server tables Jun 9, 2020
@mitchell852 mitchell852 changed the title Improve performance (pagination and search) of TP's server tables Improve performance (pagination and search) of TP's tables Jun 9, 2020
@mitchell852
Copy link
Member Author

this is only actually fixed for the servers table of TP. not all of the other tables. reopening.

@mitchell852
Copy link
Member Author

going to close this as a new ag-grid was introduced to deal with problematic tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
2 participants