-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converts all of TP's server tables to use ag-grid #4974
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell852
added
Traffic Portal v1
related to Traffic Portal version 1
improvement
The functionality exists but it could be improved in some way.
labels
Aug 19, 2020
mitchell852
changed the title
WIP: converts all of TP's server table to use ag-grid
WIP: converts all of TP's server tables to use ag-grid
Aug 19, 2020
mitchell852
changed the title
WIP: converts all of TP's server tables to use ag-grid
Converts all of TP's server tables to use ag-grid
Aug 20, 2020
mitchell852
force-pushed
the
servers-tables
branch
from
August 21, 2020 17:26
d40bf45
to
2c983ad
Compare
…ml and TableServersController can be used for cdn servers, type servers, status servers, etc...
…e and the description
mitchell852
force-pushed
the
servers-tables
branch
from
August 21, 2020 18:24
2c983ad
to
5dbbd09
Compare
ocket8888
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tables all work, code looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
The functionality exists but it could be improved in some way.
Traffic Portal v1
related to Traffic Portal version 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Converts all servers tables (cdn servers, cache group servers, ds servers, phys location servers, profile servers, status servers, type servers) from jquery datatables to the more performant, powerful ag-grid.
Note: next step is to just collapse into one servers table, however, at the moment each page view has a unique url path, breadcrumb, "More" menu and in some cases a unique context menu so I just did the easier conversion from jquery datatables to ag-grid. Next PR will collapse into one servers table...
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
-- https://tp.domain.com/#!/cdns/{id}/servers
-- https://tp.domain.com/#!/cache-groups/{id}/servers
-- https://tp.domain.com/#!/delivery-services/{id}/servers
-- https://tp.domain.com/#!/phys-locations/{id}/servers
-- https://tp.domain.com/#!/profiles/{id}/servers
-- https://tp.domain.com/#!/statuses/{id}/servers
-- https://tp.domain.com/#!/types/{id}/servers
-- https://tp.domain.com/#!/topologies/servers?name=topology-name (you'll need to create a topology for this one)
With this PR, each server table maintains it's own state. meaning you can adjust the visible columns of the cdn servers table and it will not impact the status servers table (for example). this is the current behavior of the jquery datatables, so i kept it consistent with that.
The following criteria are ALL met by this PR