Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts all of TP's server tables to use ag-grid #4974

Merged
merged 20 commits into from
Aug 26, 2020

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Aug 19, 2020

What does this PR (Pull Request) do?

Converts all servers tables (cdn servers, cache group servers, ds servers, phys location servers, profile servers, status servers, type servers) from jquery datatables to the more performant, powerful ag-grid.

Note: next step is to just collapse into one servers table, however, at the moment each page view has a unique url path, breadcrumb, "More" menu and in some cases a unique context menu so I just did the easier conversion from jquery datatables to ag-grid. Next PR will collapse into one servers table...

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

With this PR, each server table maintains it's own state. meaning you can adjust the visible columns of the cdn servers table and it will not impact the status servers table (for example). this is the current behavior of the jquery datatables, so i kept it consistent with that.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 improvement The functionality exists but it could be improved in some way. labels Aug 19, 2020
@mitchell852 mitchell852 changed the title WIP: converts all of TP's server table to use ag-grid WIP: converts all of TP's server tables to use ag-grid Aug 19, 2020
@mitchell852 mitchell852 changed the title WIP: converts all of TP's server tables to use ag-grid Converts all of TP's server tables to use ag-grid Aug 20, 2020
@mitchell852 mitchell852 marked this pull request as ready for review August 20, 2020 18:28
@mitchell852 mitchell852 marked this pull request as draft August 20, 2020 18:28
@mitchell852 mitchell852 marked this pull request as ready for review August 21, 2020 17:05
@mitchell852 mitchell852 requested a review from ocket8888 August 24, 2020 15:59
@ocket8888 ocket8888 self-assigned this Aug 24, 2020
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tables all work, code looks fine.

@ocket8888 ocket8888 merged commit 4929b9a into apache:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants