Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP: converts DS tables to more performant and powerful ag-grid #5408

Merged
merged 24 commits into from
Jan 20, 2021

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Jan 6, 2021

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  • Run UI tests
  • Navigate to one of the delivery service tables and interact with it

https://tp.domain.tld/#!/delivery-services
https://tp.domain.tld/#!/cdns/{{cdn-id}}/delivery-services
https://tp.domain.tld/#!/profiles/{{profile-id}}/delivery-services
https://tp.domain.tld/#!/service-categories/{{service-category-name}}/delivery-services
https://tp.domain.tld/#!/tenants/{{tenant-id}}/delivery-services
https://tp.domain.tld/#!/topologies/delivery-services?name={{topology-name}}
https://tp.domain.tld/#!/types/{{type-id}}/delivery-services
https://tp.domain.tld/#!/servers/{{server-id}}/delivery-services

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 marked this pull request as ready for review January 14, 2021 02:57
@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 improvement The functionality exists but it could be improved in some way. performance impacts/improves/measures performance labels Jan 14, 2021
@mitchell852 mitchell852 changed the title TP: converts DS table to ag-grid TP: converts DS tables to more performant and powerful ag-grid Jan 14, 2021
@ocket8888 ocket8888 self-assigned this Jan 14, 2021
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's a lot of duplication I just specified things in the first file in which I saw them.

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well

@ocket8888 ocket8888 merged commit 313ecfb into apache:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. performance impacts/improves/measures performance Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants