-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TP: converts DS tables to more performant and powerful ag-grid #5408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell852
added
Traffic Portal v1
related to Traffic Portal version 1
improvement
The functionality exists but it could be improved in some way.
performance
impacts/improves/measures performance
labels
Jan 14, 2021
mitchell852
changed the title
TP: converts DS table to ag-grid
TP: converts DS tables to more performant and powerful ag-grid
Jan 14, 2021
ocket8888
reviewed
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's a lot of duplication I just specified things in the first file in which I saw them.
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
Outdated
Show resolved
Hide resolved
...c_portal/app/src/common/modules/table/cdnDeliveryServices/table.cdnDeliveryServices.tpl.html
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js
Outdated
Show resolved
Hide resolved
ocket8888
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
The functionality exists but it could be improved in some way.
performance
impacts/improves/measures performance
Traffic Portal v1
related to Traffic Portal version 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
https://tp.domain.tld/#!/delivery-services
https://tp.domain.tld/#!/cdns/{{cdn-id}}/delivery-services
https://tp.domain.tld/#!/profiles/{{profile-id}}/delivery-services
https://tp.domain.tld/#!/service-categories/{{service-category-name}}/delivery-services
https://tp.domain.tld/#!/tenants/{{tenant-id}}/delivery-services
https://tp.domain.tld/#!/topologies/delivery-services?name={{topology-name}}
https://tp.domain.tld/#!/types/{{type-id}}/delivery-services
https://tp.domain.tld/#!/servers/{{server-id}}/delivery-services
The following criteria are ALL met by this PR