Add support for server search server side #4596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob05c
reviewed
Apr 3, 2020
| @@ -242,6 +242,30 @@ func getServers(params map[string]string, tx *sqlx.Tx, user *auth.CurrentUser) ( | |||
| "dsId": dbhelpers.WhereColumnInfo{"dss.deliveryservice", nil}, | |||
| } | |||
|
|
|||
| searchQueryParamsToSQLCols := map[string]dbhelpers.WhereColumnInfo{ | |||
There was a problem hiding this comment.
We should make sure all the columns we're allowing search on have indexes, to prevent performance issues and accidental or intentional DDOS
|
2 things i like about this feature:
^^ maybe this could even be changed at some point to include regex?
|
|
closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This does not completely fix the issue but it adds server side search on servers.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
There is API tests and unit tests to test the new search ability but to manually test it you need to set up the TO server with the PR and make requests to
GET 2.0/servers.The search parameters work as follows:
search- comma separated list of server attributes to searchsearchValue- string value to search with (its contains search)searchOperator- optional operator to use on the search. Can either be OR or AND. The default is OR meaning any of the search attributes must contain the searchValue to returnIf this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information
This is a stop gap solution to alleviate the load on TP as business grow their servers causing a tremendous bad user experience.
Going forward TO should adopt its own query language for searching that is not so rigid much like http://www.persvr.org/rql/ as an example