Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[SPARK-45302][PYTHON] Remove PID communication between Pythonworkers when no demon is used" #46195

Closed
wants to merge 5 commits into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR reverts #43087.

Why are the changes needed?

To clean up those workers. I will make a refactoring PR soon. I will bring them back again with a refactoring PR.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI

Was this patch authored or co-authored using generative AI tooling?

No.

… workers when no demon is used"

This reverts commit 17430fe.
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs).

@HyukjinKwon
Copy link
Member Author

Merged to master.

JacobZheng0927 pushed a commit to JacobZheng0927/spark that referenced this pull request May 11, 2024
…workers when no demon is used"

### What changes were proposed in this pull request?

This PR reverts apache#43087.

### Why are the changes needed?

To clean up those workers. I will make a refactoring PR soon. I will bring them back again with a refactoring PR.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46195 from HyukjinKwon/SPARK-45302-revert.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants